Received: with ECARTIS (v1.0.0; list xfs); Wed, 21 May 2008 00:35:46 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.3.0-r574664 Received: from cuda.sgi.com ([192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m4L7ZeBd026574 for ; Wed, 21 May 2008 00:35:40 -0700 X-ASG-Debug-ID: 1211355386-62fd01a90000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id D26601B30562; Wed, 21 May 2008 00:36:26 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id qwjVSF7eMcCcrdIy; Wed, 21 May 2008 00:36:26 -0700 (PDT) Received: from hch by bombadil.infradead.org with local (Exim 4.68 #1 (Red Hat Linux)) id 1Jyis5-0006xi-WA; Wed, 21 May 2008 07:36:26 +0000 Date: Wed, 21 May 2008 03:36:25 -0400 From: Christoph Hellwig To: Barry Naujok Cc: sgi.bugs.xfs@engr.sgi.com, xfs@oss.sgi.com X-ASG-Orig-Subj: Re: TAKE 981521 - Return actual name for CI match for dentry cache Subject: Re: TAKE 981521 - Return actual name for CI match for dentry cache Message-ID: <20080521073625.GA26580@infradead.org> References: <20080521034449.67F4758C4C29@chook.melbourne.sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080521034449.67F4758C4C29@chook.melbourne.sgi.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1211355389 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.1, rules version 3.1.50980 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/6021/Wed Feb 27 15:55:48 2008 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 16044 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: hch@infradead.org Precedence: bulk X-list: xfs On Wed, May 21, 2008 at 01:44:49PM +1000, Barry Naujok wrote: > Return case-insensitive match for dentry cache > > This implements the code to store the actual filename found > during a lookup in the dentry cache and to avoid multiple entries > in the dcache pointing to the same inode. > > To avoid polluting the dcache, we implement a new directory inode > operations for lookup. xfs_vn_ci_lookup() stores the correct case > name in the dcache. > > The "actual name" is only allocated and returned for a case- > insensitive match and not an actual match. > > Another unusual interaction with the dcache is not storing > negative dentries like other filesystems doing a d_add(dentry, NULL) > when an ENOENT is returned. During the VFS lookup, if a dentry > returned has no inode, dput is called and ENOENT is returned. > By not doing a d_add, this actually removes it completely from > the dcache to be reused. create/rename have to be modified to > support unhashed dentries being passed in. This requires the d_add_ci helper which doesn't exist in the CVS on oss.