Received: with ECARTIS (v1.0.0; list xfs); Wed, 30 Apr 2008 00:47:38 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.0-r574664 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.168.29]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m3U7lHlb018004 for ; Wed, 30 Apr 2008 00:47:25 -0700 X-ASG-Debug-ID: 1209541669-1aac02490000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from e28smtp02.in.ibm.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C653310D187 for ; Wed, 30 Apr 2008 00:47:52 -0700 (PDT) Received: from e28smtp02.in.ibm.com (e28smtp02.in.ibm.com [59.145.155.2]) by cuda.sgi.com with ESMTP id jcZI6CFpfqN59gJs for ; Wed, 30 Apr 2008 00:47:52 -0700 (PDT) Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by e28smtp02.in.ibm.com (8.13.1/8.13.1) with ESMTP id m3U7lmTI021624 for ; Wed, 30 Apr 2008 13:17:48 +0530 Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m3U7lfUe1171552 for ; Wed, 30 Apr 2008 13:17:41 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.13.1/8.13.3) with ESMTP id m3U7llNO024142 for ; Wed, 30 Apr 2008 07:47:48 GMT Received: from skywalker ([9.124.217.136]) by d28av03.in.ibm.com (8.13.1/8.12.11) with ESMTP id m3U7lg7b024078; Wed, 30 Apr 2008 07:47:44 GMT Date: Wed, 30 Apr 2008 13:17:38 +0530 From: "Aneesh Kumar K.V" To: David Chinner Cc: linux-fsdevel , linux-mm , xfs-oss X-ASG-Orig-Subj: Re: correct use of vmtruncate()? Subject: Re: correct use of vmtruncate()? Message-ID: <20080430074738.GC7791@skywalker> References: <20080429100601.GO108924158@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080429100601.GO108924158@sgi.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-Barracuda-Connect: e28smtp02.in.ibm.com[59.145.155.2] X-Barracuda-Start-Time: 1209541681 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.1, rules version 3.1.49244 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/6021/Wed Feb 27 15:55:48 2008 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 15694 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: aneesh.kumar@linux.vnet.ibm.com Precedence: bulk X-list: xfs On Tue, Apr 29, 2008 at 08:06:01PM +1000, David Chinner wrote: > Folks, > > It appears to me that vmtruncate() is not used correctly in > block_write_begin() and friends. The short summary is that it > appears that the usage in these functions implies that vmtruncate() > should cause truncation of blocks on disk but no filesystem > appears to do this, nor does the documentation imply they should. Looking at ext*_truncate, I see we are freeing blocks as a part of vmtruncate. Or did I miss something ? -aneesh