Received: with ECARTIS (v1.0.0; list xfs); Sun, 27 Apr 2008 22:59:08 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com
X-Spam-Level: 
X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham
	version=3.3.0-r574664
Received: from cuda.sgi.com (cuda1.sgi.com [192.48.168.28])
	by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m3S5wkvZ005349
	for <xfs@oss.sgi.com>; Sun, 27 Apr 2008 22:58:55 -0700
X-ASG-Debug-ID: 1209362362-425d02010000-NocioJ
X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi
Received: from bombadil.infradead.org (localhost [127.0.0.1])
	by cuda.sgi.com (Spam Firewall) with ESMTP
	id 8BD511213E80; Sun, 27 Apr 2008 22:59:22 -0700 (PDT)
Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id NPlSdSnFVAD8BA8b; Sun, 27 Apr 2008 22:59:22 -0700 (PDT)
Received: from hch by bombadil.infradead.org with local (Exim 4.68 #1 (Red Hat Linux))
	id 1JqMOY-0007h5-21; Mon, 28 Apr 2008 05:59:22 +0000
Date: Mon, 28 Apr 2008 01:59:22 -0400
From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, Greg Banks <gnb@melbourne.sgi.com>,
        xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
X-ASG-Orig-Subj: Re: [PATCH] Don't initialise new inode generation numbers to zero
	V2
Subject: Re: [PATCH] Don't initialise new inode generation numbers to zero
	V2
Message-ID: <20080428055922.GD3192@infradead.org>
References: <20080422015806.GU108924158@sgi.com> <480D641B.8060301@melbourne.sgi.com> <20080422050447.GV103491721@sgi.com> <20080425085750.GA6395@infradead.org> <20080428031120.GD103491721@sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080428031120.GD103491721@sgi.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org
	See http://www.infradead.org/rpr.html
X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34]
X-Barracuda-Start-Time: 1209362369
X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210
X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com
X-Barracuda-Spam-Score: -2.02
X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=
X-Barracuda-Spam-Report: Code version 3.1, rules version 3.1.49053
	Rule breakdown below
	 pts rule name              description
	---- ---------------------- --------------------------------------------------
X-Virus-Scanned: ClamAV 0.91.2/6021/Wed Feb 27 15:55:48 2008 on oss.sgi.com
X-Virus-Status: Clean
X-archive-position: 15633
X-ecartis-version: Ecartis v1.0.0
Sender: xfs-bounce@oss.sgi.com
Errors-to: xfs-bounce@oss.sgi.com
X-original-sender: hch@infradead.org
Precedence: bulk
X-list: xfs

On Mon, Apr 28, 2008 at 01:11:20PM +1000, David Chinner wrote:
> Ok, so is random32() good enough or does it need to be get_random_int()?

I'm not sure offhand what random32 actually is, but a not
cryptographically strong random number should be enough.