Received: with ECARTIS (v1.0.0; list xfs); Fri, 11 Apr 2008 20:01:22 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-r574664 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.168.28]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m3C31CEh029726 for ; Fri, 11 Apr 2008 20:01:14 -0700 X-ASG-Debug-ID: 1207969310-040300af0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from filer.fsl.cs.sunysb.edu (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 9608B9B8041 for ; Fri, 11 Apr 2008 20:01:51 -0700 (PDT) Received: from filer.fsl.cs.sunysb.edu (filer.fsl.cs.sunysb.edu [130.245.126.2]) by cuda.sgi.com with ESMTP id E9pDnRzpMztItnxa for ; Fri, 11 Apr 2008 20:01:51 -0700 (PDT) Received: from josefsipek.net (baal.fsl.cs.sunysb.edu [130.245.126.78]) by filer.fsl.cs.sunysb.edu (8.12.11.20060308/8.13.1) with ESMTP id m3C31m3h009891; Fri, 11 Apr 2008 23:01:48 -0400 Received: by josefsipek.net (Postfix, from userid 1000) id 19F031C00DD8; Fri, 11 Apr 2008 23:01:50 -0400 (EDT) Date: Fri, 11 Apr 2008 23:01:50 -0400 From: "Josef 'Jeff' Sipek" To: Eric Sandeen Cc: xfs-oss X-ASG-Orig-Subj: Re: [PATCH] de-duplicate calls to xfs_attr_trace_enter Subject: Re: [PATCH] de-duplicate calls to xfs_attr_trace_enter Message-ID: <20080412030150.GB5431@josefsipek.net> References: <480024CC.8040407@sandeen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <480024CC.8040407@sandeen.net> User-Agent: Mutt/1.5.16 (2007-06-11) X-Barracuda-Connect: filer.fsl.cs.sunysb.edu[130.245.126.2] X-Barracuda-Start-Time: 1207969311 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.1, rules version 3.1.47537 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/6021/Wed Feb 27 15:55:48 2008 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 15399 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: jeffpc@josefsipek.net Precedence: bulk X-list: xfs On Fri, Apr 11, 2008 at 09:56:12PM -0500, Eric Sandeen wrote: > Every call to xfs_attr_trace_enter() shares the exact > same 16 args in the middle... just send in the context > pointer and let the next level down split it into the > ktrace. > > Compile tested only. Very nice. Josef 'Jeff' Sipek. -- I think there is a world market for maybe five computers. - Thomas Watson, chairman of IBM, 1943.