Received: with ECARTIS (v1.0.0; list xfs); Sun, 20 Jan 2008 18:15:33 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_43 autolearn=no version=3.3.0-r574664 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with SMTP id m0L2FOqV028227 for ; Sun, 20 Jan 2008 18:15:29 -0800 Received: from pc-bnaujok.melbourne.sgi.com (pc-bnaujok.melbourne.sgi.com [134.14.55.58]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id NAA20490; Mon, 21 Jan 2008 13:15:37 +1100 To: "Eric Sandeen" Subject: Re: [REVIEW 2/2] Case insensitive support for XFS - user-space From: "Barry Naujok" Organization: SGI Cc: "xfs@oss.sgi.com" , xfs-dev Content-Type: text/plain; format=flowed; delsp=yes; charset=utf-8 MIME-Version: 1.0 References: <479118CF.1020302@sandeen.net> <47919214.9000807@sandeen.net> Date: Mon, 21 Jan 2008 13:16:17 +1100 Message-ID: In-Reply-To: User-Agent: Opera Mail/9.24 (Win32) X-Virus-Scanned: ClamAV 0.91.2/5505/Sun Jan 20 15:48:59 2008 on oss.sgi.com X-Virus-Status: Clean Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from Quoted-Printable to 8bit by oss.sgi.com id m0L2FUqV028232 X-archive-position: 14214 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: bnaujok@sgi.com Precedence: bulk X-list: xfs On Mon, 21 Jan 2008 13:07:21 +1100, Barry Naujok wrote: > On Sat, 19 Jan 2008 17:00:52 +1100, Eric Sandeen > wrote: > >> Eric Sandeen wrote: >> >>> Also, if I specify -nutf8=default on a 500m fs: >>> >>> # mkfs.xfs -dfile,name=fsfile,size=500m -nutf8=default >>> meta-data=fsfile isize=256 agcount=4, agsize=32000 >>> blks >>> = sectsz=512 attr=2 >>> data = bsize=4096 blocks=128000, imaxpct=25 >>> = sunit=0 swidth=0 blks >>> naming =version 2 bsize=4096 utf8=default >>> log =internal log bsize=4096 blocks=1200, version=2 >>> = sectsz=512 sunit=0 blks, >>> lazy-count=0 >>> realtime =none extsz=4096 blocks=0, rtextents=0 >>> mkfs.xfs: cannot reserve space: No space left on device >> >> /* >> * allocate the inode >> */ >> tp = libxfs_trans_alloc(mp, 0); >> error = libxfs_trans_reserve(tp, XFS_CREATE_LOG_RES(mp), 0, 0, >> 0, 0); > > Can you try this instead? > > error = libxfs_trans_reserve(tp, XFS_IALLOC_BLOCKS(mp) + > (XFS_IN_MAXLEVELS(mp) - 1), 0, 0, 0, 0); BTW. this fix works for me :) >> if (error) { >> fprintf(stderr, _("%s: 1: cannot reserve space: %s >> (%d)\n"), >> progname, strerror(error), >> XFS_CREATE_LOG_RES(mp)); >> exit(1); >> } >> >> >> I think there are some wrong arguments to that trans_reserve... at least >> XFS_CREATE_LOG_RES should be 3rd arg, no? >> >> -Eric > > > >