Received: with ECARTIS (v1.0.0; list xfs); Sun, 20 Jan 2008 19:46:35 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-r574664 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.168.28]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m0L3kQCS001928 for ; Sun, 20 Jan 2008 19:46:28 -0800 X-ASG-Debug-ID: 1200887201-58d0012d0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from sandeen.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5D6A9CAAF8E for ; Sun, 20 Jan 2008 19:46:41 -0800 (PST) Received: from sandeen.net (sandeen.net [209.173.210.139]) by cuda.sgi.com with ESMTP id aZfDu9uos8T83coI for ; Sun, 20 Jan 2008 19:46:41 -0800 (PST) Received: from Liberator.local (liberator.sandeen.net [10.0.0.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by sandeen.net (Postfix) with ESMTP id 72ED318D9045B; Sun, 20 Jan 2008 21:46:39 -0600 (CST) Message-ID: <4794159F.9070505@sandeen.net> Date: Sun, 20 Jan 2008 21:46:39 -0600 From: Eric Sandeen User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: xfs-oss , Niv Sardi X-ASG-Orig-Subj: small problem w/ new xfs defaults patch Subject: small problem w/ new xfs defaults patch Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: sandeen.net[209.173.210.139] X-Barracuda-Start-Time: 1200887206 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=3.0 tests= X-Barracuda-Spam-Report: Code version 3.1, rules version 3.1.40039 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/5505/Sun Jan 20 15:48:59 2008 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 14217 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: sandeen@sandeen.net Precedence: bulk X-list: xfs Index: xfsprogs-2.9.4/growfs/xfs_growfs.c =================================================================== --- xfsprogs-2.9.4.orig/growfs/xfs_growfs.c +++ xfsprogs-2.9.4/growfs/xfs_growfs.c @@ -58,7 +58,6 @@ report_info( int isint, char *logname, char *rtname, - int unwritten, int lazycount, int dirversion, int logversion, @@ -68,7 +67,7 @@ report_info( "meta-data=%-22s isize=%-6u agcount=%u, agsize=%u blks\n" " =%-22s sectsz=%-5u attr=%u\n" "data =%-22s bsize=%-6u blocks=%llu, imaxpct=%u\n" - " =%-22s sunit=%-6u swidth=%u blks, unwritten=%u\n" + " =%-22s sunit=%-6u swidth=%u blks" "naming =version %-14u bsize=%-6u\n" "log =%-22s bsize=%-6u blocks=%u, version=%u\n" " =%-22s sectsz=%-5u sunit=%u blks, lazy-count=%u\n" couple things... you lost a "\n" off the end of the data section there... Also, do you really want to drop reporting of unwritten extents? Even if you're disallowing the selection on new mkfs's there may still be different flavors of filesystems in existence, should it still be reported? -Eric