Received: with ECARTIS (v1.0.0; list xfs); Sun, 20 Jan 2008 20:12:58 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-r574664 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with SMTP id m0L4CpK4004631 for ; Sun, 20 Jan 2008 20:12:54 -0800 Received: from snort.melbourne.sgi.com (snort.melbourne.sgi.com [134.14.54.149]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id PAA22870; Mon, 21 Jan 2008 15:13:01 +1100 Received: from snort.melbourne.sgi.com (localhost [127.0.0.1]) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5) with ESMTP id m0L4D0LF32440745; Mon, 21 Jan 2008 15:13:01 +1100 (AEDT) Received: (from dgc@localhost) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5/Submit) id m0L4Cwwd32457968; Mon, 21 Jan 2008 15:12:58 +1100 (AEDT) X-Authentication-Warning: snort.melbourne.sgi.com: dgc set sender to dgc@sgi.com using -f Date: Mon, 21 Jan 2008 15:12:58 +1100 From: David Chinner To: Christoph Hellwig Cc: "Josef 'Jeff' Sipek" , xfs@oss.sgi.com Subject: Re: [PATCH 1/1] XFS: Replace custom AIL linked-list code with struct list_head Message-ID: <20080121041258.GZ155259@sgi.com> References: <1200875757-26598-1-git-send-email-jeffpc@josefsipek.net> <20080121040422.GA25541@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080121040422.GA25541@infradead.org> User-Agent: Mutt/1.4.2.1i X-Virus-Scanned: ClamAV 0.91.2/5505/Sun Jan 20 15:48:59 2008 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 14221 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs On Mon, Jan 21, 2008 at 04:04:23AM +0000, Christoph Hellwig wrote: > On Sun, Jan 20, 2008 at 07:35:57PM -0500, Josef 'Jeff' Sipek wrote: > > Signed-off-by: Josef 'Jeff' Sipek > > --- > > > > I tested it with xfsqa, and things work as well as they do without it. > > I like this a lot, but I think Dave has plans to replace the linked list > with a more efficient data structure soon, so it might not actually be > worth applying. Doesn't really make any difference to me - i've got to rebase the patch on the xfsaild thread commit anyway.... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group