DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references;
        b=qogWKHDaP0qAOLEfPvv/Rb+hXm/gur0LikbahJvvscOwTK+pJQiKjuJpikQ9d+oLGMiBaY7wncddsBV3OOhmSVvNN3qpenqZ7Tk+k40+cv0TjIpZtfSx5RLJ6iVsOztlivtyH9VFpclbxqAq5pNjA6JUckc/1owbi+Q7eNEhZ7U=
Message-ID: <cc7060690711051042h5c39c540mf60f95e2f67c7bd7@mail.gmail.com>
Date: Tue, 6 Nov 2007 00:12:52 +0530
From: "Bhagi rathi" <jahnu77@gmail.com>
To: "David Chinner" <dgc@sgi.com>
Subject: Re: TAKE 972756 - Implement fallocate.
Cc: sgi.bugs.xfs@engr.sgi.com, xfs@oss.sgi.com
In-Reply-To: <20071102024314.9BF3458C38F7@chook.melbourne.sgi.com>
MIME-Version: 1.0
References: <20071102024314.9BF3458C38F7@chook.melbourne.sgi.com>
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Content-length: 1134
Sender: xfs-bounce@oss.sgi.com
Errors-to: xfs-bounce@oss.sgi.com
Precedence: bulk

David, What happens if offset is not aligned to 4k? Let's say we have a file
whose size is
not aligned to 4k. It could have blocks beyond the eof which haven't been
zero'ed out.
fallocate may increase the size and we can read garbage from disk-block if
it hasn't
been zero'ed out.

-Thanks,
 Bhagi.

On 11/2/07, David Chinner <dgc@sgi.com> wrote:
>
> Implement fallocate.
>
> Implement the new generic callout for file preallocation.
> Atomically change the file size if requested.
>
>
> Date:  Fri Nov  2 13:42:52 AEDT 2007
> Workarea:  chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
> Inspected by:  hch@infradead.org
>
> The following file(s) were checked into:
>   longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
>
>
> Modid:  xfs-linux-melb:xfs-kern:30009a
> fs/xfs/linux-2.6/xfs_iops.c - 1.268 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/> linux-2.6/xfs_iops.c.diff?r1=text&tr1=1.268&r2=text&tr2=1.267&f=h
>
> http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_iops.c.diff?r1=text&tr1=1.268&r2=text&tr2=1.267&f=h
>         - implement ->fallocate()
>
>
>
>


[[HTML alternate version deleted]]