Received: with ECARTIS (v1.0.0; list xfs); Wed, 21 Nov 2007 07:20:19 -0800 (PST)
X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham
	version=3.3.0-r574664
Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40])
	by oss.sgi.com (8.12.11.20060308/8.12.10/SuSE Linux 0.7) with ESMTP id lALFJwge007767
	for <xfs@oss.sgi.com>; Wed, 21 Nov 2007 07:20:12 -0800
Received: from hch by pentafluge.infradead.org with local (Exim 4.63 #1 (Red Hat Linux))
	id 1IurN0-0002TF-Ga; Wed, 21 Nov 2007 15:20:06 +0000
Date: Wed, 21 Nov 2007 15:20:06 +0000
From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH,RFC] Factor some btree code....
Message-ID: <20071121152006.GD8454@infradead.org>
References: <20071106091836.GV995458@sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071106091836.GV995458@sgi.com>
User-Agent: Mutt/1.4.2.3i
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by pentafluge.infradead.org
	See http://www.infradead.org/rpr.html
X-Virus-Scanned: ClamAV 0.91.2/4872/Wed Nov 21 00:36:49 2007 on oss.sgi.com
X-Virus-Status: Clean
X-archive-position: 13717
X-ecartis-version: Ecartis v1.0.0
Sender: xfs-bounce@oss.sgi.com
Errors-to: xfs-bounce@oss.sgi.com
X-original-sender: hch@infradead.org
Precedence: bulk
X-list: xfs


I like this.  But I think a single set of xfs_btree_ops would be a lot
more readable.  Also I'm not sure we actually need all these ops, e.g.
instead of .buf_to_block we could always just call XFS_BUF_PTR directly.