Received: with ECARTIS (v1.0.0; list xfs); Tue, 21 Nov 2006 20:48:00 -0800 (PST) Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id kAM4lnaG031816 for ; Tue, 21 Nov 2006 20:47:51 -0800 Received: from snort.melbourne.sgi.com (snort.melbourne.sgi.com [134.14.54.149]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id PAA29658; Wed, 22 Nov 2006 15:46:58 +1100 Received: from snort.melbourne.sgi.com (localhost [127.0.0.1]) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5) with ESMTP id kAM4kv7Y42662921; Wed, 22 Nov 2006 15:46:58 +1100 (AEDT) Received: (from dgc@localhost) by snort.melbourne.sgi.com (SGI-8.12.5/8.12.5/Submit) id kAM4kudL42646968; Wed, 22 Nov 2006 15:46:56 +1100 (AEDT) Date: Wed, 22 Nov 2006 15:46:56 +1100 From: David Chinner To: xfs-dev@sgi.com Cc: xfs@oss.sgi.com Subject: Review: Fix inverted quiet mount logic Message-ID: <20061122044656.GS37654165@melbourne.sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.1i X-archive-position: 9731 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: dgc@sgi.com Precedence: bulk X-list: xfs Content-Length: 1087 Lines: 32 Simple problem Noticed by Eric Sandeen at about the same time I did - we are not getting error messages in dmesg when certain checks fail during mount. Turns out the XFS_MFSI_QUIET flag usage is inverted, so we suppress messages when we should be noisy and shout when we should be silent.... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group --- fs/xfs/xfs_error.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: 2.6.x-xfs-new/fs/xfs/xfs_error.h =================================================================== --- 2.6.x-xfs-new.orig/fs/xfs/xfs_error.h 2006-10-17 12:17:25.000000000 +1000 +++ 2.6.x-xfs-new/fs/xfs/xfs_error.h 2006-11-16 09:45:03.444451972 +1100 @@ -180,6 +180,6 @@ extern void xfs_fs_cmn_err(int level, st xfs_fs_cmn_err(level, mp, fmt " Unmount and run xfs_repair.", ## args) #define xfs_fs_mount_cmn_err(f, fmt, args...) \ - ((f & XFS_MFSI_QUIET)? cmn_err(CE_WARN, "XFS: " fmt, ## args) : (void)0) + ((f & XFS_MFSI_QUIET)? (void)0 : cmn_err(CE_WARN, "XFS: " fmt, ## args)) #endif /* __XFS_ERROR_H__ */