Received: with ECARTIS (v1.0.0; list xfs); Sat, 11 Nov 2006 03:09:27 -0800 (PST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.168.28]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id kABB9IaG025713 for ; Sat, 11 Nov 2006 03:09:19 -0800 X-ASG-Debug-ID: 1163242590-11896-301-0 X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40]) by cuda.sgi.com (Spam Firewall) with ESMTP id D4443515DA2 for ; Sat, 11 Nov 2006 02:56:31 -0800 (PST) Received: from hch by pentafluge.infradead.org with local (Exim 4.63 #1 (Red Hat Linux)) id 1GiqXD-0001Cp-2K; Sat, 11 Nov 2006 10:56:27 +0000 Date: Sat, 11 Nov 2006 10:56:27 +0000 From: Christoph Hellwig To: Eric Sandeen Cc: xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH] remove unused filp from ioctl functions Subject: Re: [PATCH] remove unused filp from ioctl functions Message-ID: <20061111105627.GB3356@infradead.org> References: <4555437B.4040904@sandeen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4555437B.4040904@sandeen.net> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.02, rules version 3.0.25681 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-archive-position: 9596 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: hch@infradead.org Precedence: bulk X-list: xfs Content-Length: 318 Lines: 7 On Fri, Nov 10, 2006 at 09:28:59PM -0600, Eric Sandeen wrote: > There's a stuct file * passed around the ioctl code that is never > used... just takes up precious stack space near as I can tell :) While you're at it kill the inode paramater anyway, it can be retrieved from the vnode by trivial address arithmetics.