Message-ID: <44F2948C.4070005@sgi.com>
Date: Mon, 28 Aug 2006 17:00:28 +1000
From: Vlad Apostolov <vapo@sgi.com>
User-Agent: Thunderbird 1.5.0.5 (X11/20060719)
MIME-Version: 1.0
To: Nathan Scott <nathans@sgi.com>
CC: xfs@oss.sgi.com
Subject: Re: review: greedy allocator vs kmflags
References: <20060828163004.B3100886@wobbly.melbourne.sgi.com>
In-Reply-To: <20060828163004.B3100886@wobbly.melbourne.sgi.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: xfs-bounce@oss.sgi.com
Errors-to: xfs-bounce@oss.sgi.com
Precedence: bulk
Content-Length: 692
Lines: 23

Nathan Scott wrote:
> Hi Vlad,
>
> This is the last iteration on updating the greedy alloc routine to
> be more generic and properly handle the passed in flags wrt sleep or
> nosleep (following up on Dave's suggestion, and someone else to me
> privately, offlist).  Could you give it a final review for me?
>
> thanks.
>
>   
It is looking good Nathan. One thing I noticed today when I was building 
the modules
was that kmem_zalloc_greedy() is already in use in several places. There
were a few warnings about type mismatch of the first argument "size_t 
*size" and
missing kmem_zalloc_greedy symbol at the end. Not sure if this is 
important but just
thought to mention it.

Regards,
Vlad