Received: with ECARTIS (v1.0.0; list linux-xfs); Fri, 13 May 2005 09:04:24 -0700 (PDT) Received: from cirse.extra.cea.fr (cirse.extra.cea.fr [132.166.172.102]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id j4DG4JOv011481 for ; Fri, 13 May 2005 09:04:20 -0700 Received: from argiope.saclay.cea.fr (argiope.saclay.cea.fr [132.166.192.108]) by cirse.extra.cea.fr (8.12.10/8.12.10/CEAnet-Internet.4.0) with ESMTP id j4DG3oAN021782 for ; Fri, 13 May 2005 18:03:50 +0200 (MEST) Received: from pisaure.intra.cea.fr (unverified) by argiope.saclay.cea.fr (Content Technologies SMTPRS 4.3.17) with ESMTP id ; Fri, 13 May 2005 18:03:50 +0200 Received: from nenuphar.saclay.cea.fr (nenuphar.saclay.cea.fr [132.166.192.7]) by pisaure.intra.cea.fr (8.12.11/8.12.11) with ESMTP id j4DG1uii011414; Fri, 13 May 2005 18:01:56 +0200 (envelope-from degremont@ocre.cea.fr) Received: from ocre.cea.fr ([132.165.65.70]) by nenuphar.saclay.cea.fr (8.12.10/8.12.10/CEAnet-internes.4.0) with ESMTP id j4DG3nZa022353; Fri, 13 May 2005 18:03:49 +0200 (MEST) Message-ID: <4284CFE5.60004@ocre.cea.fr> Date: Fri, 13 May 2005 18:03:49 +0200 From: Aurelien Degremont - Stagiaire User-Agent: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.2.1) Gecko/20030225 X-Accept-Language: en-us MIME-Version: 1.0 To: Dean Roehrich CC: linux-xfs@oss.sgi.com Subject: Re: [DMAPI] code error in dm_ip_to_handle() References: <20050513152947.909404FE8A@chewtoy.americas.sgi.com> In-Reply-To: <20050513152947.909404FE8A@chewtoy.americas.sgi.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-archive-position: 5220 X-ecartis-version: Ecartis v1.0.0 Sender: linux-xfs-bounce@oss.sgi.com Errors-to: linux-xfs-bounce@oss.sgi.com X-original-sender: degremont@ocre.cea.fr Precedence: bulk X-list: linux-xfs Content-Length: 868 Lines: 26 Dean Roehrich a écrit: > Certainly, dm_handle_to_ip() is intended to return any type of handle, > including filesystem handles. In the case of XFS, when a filesystem handle is > requested we contruct it from the filesystem's root vnode. > > I suppose dm_handle_to_ip() could be called with the handle from the mount > event. That handle would have a fid_len of 0, due to the memset() in > dm_sb_data()...the HSM would call to things like dm_get_config() and > dm_set_disp() with that handle. Yes, in fh_to_inode(), we could recognize the fshandle, using the fid_len value. But, in inode_to_fh(), how know that we must return a fshandle (with the dm_fid part filled with 0) or a filehandle (ino, len and gen filled) ? What's the difference between dm_path_to_fshandle("/") and dm_path_to_handle("/") ? (Assuming / is a DMAPI compatible filesystem) Aurelien