Received: with ECARTIS (v1.0.0; list linux-xfs); Fri, 30 Aug 2002 00:53:55 -0700 (PDT) Received: from questra.com (IDENT:qmailr@ns1.questra.com [64.132.48.186]) by oss.sgi.com (8.12.5/8.12.5) with SMTP id g7U7rntG006508 for ; Fri, 30 Aug 2002 00:53:49 -0700 Received: (qmail 14122 invoked from network); 30 Aug 2002 07:57:28 -0000 Received: from hades.roc.questra.com (HELO questra.com) (64.132.48.226) by ns1.questra.com with SMTP; 30 Aug 2002 07:57:28 -0000 Received: (qmail 26728 invoked from network); 30 Aug 2002 07:57:28 -0000 Received: from odio.roc.questra.com (10.20.8.26) by hades.roc.questra.com with SMTP; 30 Aug 2002 07:57:28 -0000 Received: (from mcdermot@localhost) by odio.roc.questra.com (8.11.6/8.11.4) id g7U7vSN30477 for linux-xfs@oss.sgi.com; Fri, 30 Aug 2002 03:57:28 -0400 Date: Fri, 30 Aug 2002 03:57:28 -0400 From: Scott McDermott To: xfs mailing list Subject: Re: snapshot regression test try 2 Message-ID: <20020830035728.A15469@questra.com> Mail-Followup-To: xfs mailing list References: <20020829232620.LRFR28682.imf05bis.bellsouth.net@TAZ2> <20020829232659.F17654@plato.local.lan> Mime-Version: 1.0 Content-type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20020829232659.F17654@plato.local.lan>; from erbenson@alaska.net on Thu, Aug 29, 2002 at 11:26:59PM -0800 Content-Transfer-Encoding: 8bit X-archive-position: 163 X-ecartis-version: Ecartis v1.0.0 Sender: linux-xfs-bounce@oss.sgi.com Errors-to: linux-xfs-bounce@oss.sgi.com X-original-sender: mcdermot@questra.com Precedence: bulk X-list: linux-xfs Ethan Benson on Thu 29/08 23:26 -0800: > you can argue that im being pedantic and the lack of quoting will > probably not matter in this script, but in some cases its just too > dangerous not to. nahh, for instance mktemp will never give you spaces or anything like that. Why quote when you can always guarantee you don't need to? I think scripts which quote everything just to be safe for no reason are silly. Not that every case in the script was like that. > also you should never assume that there are not hostile users messing > with /tmp. yeah PID is too predictable, plus it wraps