Received: from oss.sgi.com (localhost [127.0.0.1])
	by oss.sgi.com (8.12.5/8.12.5) with ESMTP id g7JJcFRw032167
	for <linux-xfs-outgoing@oss.sgi.com>; Mon, 19 Aug 2002 12:38:15 -0700
Received: (from majordomo@localhost)
	by oss.sgi.com (8.12.5/8.12.3/Submit) id g7JJcFGl032166
	for linux-xfs-outgoing; Mon, 19 Aug 2002 12:38:15 -0700
X-Authentication-Warning: oss.sgi.com: majordomo set sender to owner-linux-xfs@oss.sgi.com using -f
Received: from zeus-e8.americas.sgi.com ([198.149.7.250])
	by oss.sgi.com (8.12.5/8.12.5) with SMTP id g7JJbxRw032091
	for <linux-xfs@oss.sgi.com>; Mon, 19 Aug 2002 12:37:59 -0700
Received: from poppy-e185.americas.sgi.com (poppy-e185.americas.sgi.com [128.162.185.207]) by zeus-e8.americas.sgi.com (SGI-8.9.3/americas-smart-nospam1.1) with ESMTP id OAA67315; Mon, 19 Aug 2002 14:40:45 -0500 (CDT)
Received: from stout.americas.sgi.com (stout.americas.sgi.com [128.162.187.5]) by poppy-e185.americas.sgi.com (980427.SGI.8.8.8/SGI-server-1.8) with ESMTP id OAA95126; Mon, 19 Aug 2002 14:40:45 -0500 (CDT)
Subject: Re: Conflicting Types Between .h and .c files
From: Eric Sandeen <sandeen@sgi.com>
To: Danny Cox <DCox@SnapServer.com>
Cc: Christoph Hellwig <hch@infradead.org>,
   XFS Mailing List
	 <linux-xfs@oss.sgi.com>
In-Reply-To: <1029783129.1147.37.camel@wiley>
References: <1029504550.1808.5.camel@wiley>
	<20020819194735.A32101@infradead.org>  <1029783129.1147.37.camel@wiley>
Content-Type: text/plain; charset=ISO-8859-1
X-Mailer: Ximian Evolution 1.0.3 (1.0.3-6) 
Date: 19 Aug 2002 14:40:08 -0500
Message-Id: <1029786008.12970.42.camel@stout.americas.sgi.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by oss.sgi.com id g7JJc0Rw032097
X-Spam-Status: No, hits=-4.4 required=5.0 tests=IN_REP_TO version=2.20
X-Spam-Level: 
Sender: owner-linux-xfs@oss.sgi.com
Precedence: bulk

Danny - FWIW, xfs compiles for me with no warnings, using gcc version
2.96 20000731 (Red Hat Linux 7.3 2.96-110) on today's CVS tree.

-Eric

On Mon, 2002-08-19 at 13:52, Danny Cox wrote:
> Christoph,
> 
> On Mon, 2002-08-19 at 14:47, Christoph Hellwig wrote:
> > > while the .c file sez its:
> > > 
> > > 	kmem_zone_t *<grump>;
> > > 
> > > While I know it's the same thing, the compiler (2.96 from RH) apparently
> > 
> > I don't think that's valid.  And at least gcc 3.2 doesn't complain..
> 
> 	Yes, but 2.96 does.  I'd think that several folks use 2.96, since
> that's the standard gcc from RH 7.2.
> 
> > In this case not, as the kmem_zone_t is an object opaque to it's user.
> > Compare it to kmem_cache_t in þhe core Linux code.
> 
> 	Okay, point taken.  Nevertheless, the types between the .c and .h files
> should be consistent, whatever is chosen, no?
> 
> -- 
> kernel, n.: A part of an operating system that preserves the
> medieval traditions of sorcery and black art.
> 
> Danny
> 
-- 
Eric Sandeen      XFS for Linux     http://oss.sgi.com/projects/xfs
sandeen@sgi.com   SGI, Inc.         651-683-3102