Date: Thu, 31 Jan 2002 02:16:28 +0100
From: utz lehmann <xfs@s2y4n2c.de>
To: Eric Sandeen <sandeen@sgi.com>
Cc: linux-xfs@oss.sgi.com
Subject: Re: TAKE - 1 step closer to removing -funsigned-char
Message-ID: <20020131021628.A1035@s2y4n2c.de>
References: <200201302221.g0UMLnn12879@stout.americas.sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200201302221.g0UMLnn12879@stout.americas.sgi.com>
Sender: owner-linux-xfs@oss.sgi.com
Precedence: bulk
Status: O
Content-Length: 1197
Lines: 40

Hi Eric

Eric Sandeen [sandeen@sgi.com] wrote:
> XFS on Irix gets to assume chars are unsigned, which is not true
> on Linux, so we use the -funsigned-char option when we build it.
> Getting rid of this would be nice; we can explicitly define unsigned
> chars when we need them.  The trick is figuring out when we need them.  :)
> 
> These changes should fix the international character problems some were
> seeing when -funsigned-char was turned off; if some of those brave souls
> could turn off -funsigned-char on their machines and give it another go,
> reports of success or failure would be welcome.  :)

Ok, here is my report of success.-)

I wrote a perl script that touches 96 files. Each file begins with a
different 8bit character (160 - 255) and have a random filename length.

I removed -funsigned-char from linux/fs/xfs/Makefile and
linux/fs/xfs/linux/Makefile.

I created files with 2.4.9 and checkt it with 2.4.17 and vice versa.
"ls -l" and removing works. No Problems.


utz


Here is the script:

foreach $c0 (0 .. 95) {
	$f = "";
	foreach $c1 ($c0 .. ($c0 + int( rand(17) + 5))) {
		$c = ($c1 % 96) + 160;
		$f .= sprintf("%c", $c);
	}
#	print "$f\n";
	system ("touch $f");
}