Subject: Re: [PATCH] Re: Reduce XFS footprint (was Re: TAKE - remove
	a	function xfs added to filemap.c
From: Steve Lord <lord@sgi.com>
To: "Ralf G. R. Bergs" <rabe@RWTH-Aachen.DE>
Cc: "linux-xfs@oss.sgi.com" <linux-xfs@oss.sgi.com>
In-Reply-To: <E16VerN-0006ud-00@ADSL-Bergs.RZ.RWTH-Aachen.DE>
References: <E16VerN-0006ud-00@ADSL-Bergs.RZ.RWTH-Aachen.DE>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: 29 Jan 2002 14:41:10 -0600
Message-Id: <1012336870.26363.14.camel@jen.americas.sgi.com>
Mime-Version: 1.0
Sender: owner-linux-xfs@oss.sgi.com
Precedence: bulk
Status: O
Content-Length: 1568
Lines: 41

On Tue, 2002-01-29 at 14:28, Ralf G. R. Bergs wrote:
> On Tue, 29 Jan 2002 13:09:17 -0600, Steve Lord wrote:
> 
> [...]
> >XFS has two directory formats, V1 directories were the original, V2 was
> >a new version written to fix problems with NFS and a few other apps.
> >Linux always uses V2, the V1 is there for Irix compatibility - but it
> >can get into loops or miss entries in readdir on linux.
> 
> So with Andi's patch one should NOT enable V1 directories, or otherwise the XFS 
> code can't read existing V2 filesystems anymore? Is that right?


Noooo, I think you got your 1s and 2s crossed in there. Andi was turning
off the backwards compatibility with old irix filesystems (V1) in the 
patch. It is not exactly a huge win spacewise, but every little helps.
This will not affect any existing filesystem made on linux since they
all use the V2 code.

Right now we are not sure Andi's patch really works for removal of the
directory code, since the file he is removing contains functions which
are called from V2 code. I would hold off using any of this stuff until
we have sorted it all out.

Steve

> 
> Thanks.
> 
> 
> -- 
> Verkaufe Original-BMW-Raeder:                    L I N U X       .~.
> http://adsl-bergs.rz.rwth-aachen.de/~rabe       The  Choice      /V\
>                                                  of a  GNU      /( )\
>                                                 Generation      ^^-^^
> 
-- 

Steve Lord                                      voice: +1-651-683-3511
Principal Engineer, Filesystem Software         email: lord@sgi.com