Received: (from majordomo@localhost) by oss.sgi.com (8.11.2/8.11.3) id g07Js5P22635 for linux-xfs-outgoing; Mon, 7 Jan 2002 11:54:05 -0800 Received: from rj.sgi.com (rj.sgi.com [204.94.215.100]) by oss.sgi.com (8.11.2/8.11.3) with SMTP id g07Jrug22610 for ; Mon, 7 Jan 2002 11:53:56 -0800 Received: from zeus-fddi.americas.sgi.com (zeus-fddi.americas.sgi.com [128.162.8.103]) by rj.sgi.com (8.11.4/8.11.4/linux-outbound_gateway-1.1) with ESMTP id g07IrnY02882 for ; Mon, 7 Jan 2002 10:53:49 -0800 Received: from daisy-e185.americas.sgi.com (daisy-e185.americas.sgi.com [128.162.185.214]) by zeus-fddi.americas.sgi.com (8.9.3/americas-smart-nospam1.1) with ESMTP id MAA3955412; Mon, 7 Jan 2002 12:52:33 -0600 (CST) Received: from jen.americas.sgi.com (jen.americas.sgi.com [128.162.187.49]) by daisy-e185.americas.sgi.com (SGI-8.9.3/SGI-server-1.7) with ESMTP id MAA41597; Mon, 7 Jan 2002 12:52:32 -0600 (CST) Received: by jen.americas.sgi.com (8.11.6/SGI-client-1.7) id g07IprM14629; Mon, 7 Jan 2002 12:51:53 -0600 Subject: Re: file corruption during emacs build on XFS logical volume From: Steve Lord To: Sean Neakums Cc: Linux XFS In-Reply-To: <6uheq0fsu6.fsf@zork.zork.net> References: <1010174871.30053.6.camel@jen.americas.sgi.com> <1010176193.2938.14.camel@UberGeek> <1010176393.30037.9.camel@jen.americas.sgi.com> <1010179700.30053.13.camel@jen.americas.sgi.com> <1010187371.30053.32.camel@jen.americas.sgi.com> <6uy9jdhdsr.fsf@zork.zork.net> <6upu4ph8c5.fsf@zork.zork.net> <3C37511F.6050809@sgi.com> <6uheq0fsu6.fsf@zork.zork.net> Content-Type: multipart/mixed; boundary="=-25Rb1XxbJy2ZcU8Tijge" X-Mailer: Evolution/1.0.0.99+cvs.2001.12.18.08.57 (Preview Release) Date: 07 Jan 2002 12:51:53 -0600 Message-Id: <1010429513.7120.35.camel@jen.americas.sgi.com> Mime-Version: 1.0 Sender: owner-linux-xfs@oss.sgi.com Precedence: bulk Status: O Content-Length: 2214 Lines: 69 --=-25Rb1XxbJy2ZcU8Tijge Content-Type: text/plain Content-Transfer-Encoding: 7bit On Sat, 2002-01-05 at 14:25, Sean Neakums wrote: > begin Stephen Lord quotation: > > > OK, thanks, this narrows it down even more than I had - I was > > running a kernel from Dec 22nd and recreating the problem. I had > > tried the individual patches to the I/O path and failed to recreate > > it - but maybe I should try that again. > > I just found a kernel from December 8 (I had removed it from > lilo.conf, but forgotten to delete the kernel itself and the modules) > and I cannot recreate on that. > Sean, can you see if the attached patch against the current cvs tree fixes the problem for you? So far I have not been able to reproduce with this change. Steve -- Steve Lord voice: +1-651-683-3511 Principal Engineer, Filesystem Software email: lord@sgi.com --=-25Rb1XxbJy2ZcU8Tijge Content-Disposition: attachment; filename=emacs.patch Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=ISO-8859-1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Index: linux/fs/pagebuf/page_buf_io.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- /usr/tmp/TmpDir.14614-0/linux/fs/pagebuf/page_buf_io.c_1.104 Mon Jan 7= 12:49:22 2002 +++ linux/fs/pagebuf/page_buf_io.c Mon Jan 7 10:58:43 2002 @@ -1340,6 +1340,7 @@ do { lock_buffer(bh); clear_bit(BH_Delay, &bh->b_state); +/**** if (atomic_set_buffer_clean(bh)) { get_bh(bh); bh->b_end_io =3D end_buffer_io_sync; @@ -1349,6 +1350,12 @@ unlock_buffer(bh); refile_buffer(bh); } +***/ + atomic_set_buffer_clean(bh); + get_bh(bh); + bh->b_end_io =3D end_buffer_io_sync; + refile_buffer(bh); + array[count++] =3D bh; bh =3D bh->b_this_page; } while (bh !=3D head); =20 --=-25Rb1XxbJy2ZcU8Tijge--