Received: by oss.sgi.com id ; Thu, 18 May 2000 22:35:35 +0000 Received: from [216.208.98.2] ([216.208.98.2]:21230 "EHLO moiraine.off.net") by oss.sgi.com with ESMTP id ; Thu, 18 May 2000 22:35:19 +0000 Received: (from phil@localhost) by moiraine.off.net (8.9.3/8.9.3) id SAA21698; Thu, 18 May 2000 18:33:48 -0400 Date: Thu, 18 May 2000 18:33:48 -0400 From: Phil Schwan To: Russell Cattelan Cc: linux-xfs@oss.sgi.com, slinx-xfs@engr.sgi.com Subject: Re: header dependency patch Message-ID: <20000518183348.F15745@linuxcare.com> References: <20000518180157.E15745@linuxcare.com> <39246B6B.23C4278@thebarn.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.4us In-Reply-To: <39246B6B.23C4278@thebarn.com>; from Russell Cattelan on Thu, May 18, 2000 at 05:15:07PM -0500 Sender: owner-linux-xfs@oss.sgi.com Precedence: bulk Return-Path: X-Orcpt: rfc822;linux-xfs-outgoing On May 18, Russell Cattelan wrote: > Phil Schwan wrote: > > > While hacking files from scratch, I noticed the huge number of > > dependencies that #includes don't resolve for themselves. Is there > > some reason for this, or did it just happen over time? Does anyone > > mind if I apply this patch? It doesn't fix them all, but it gets the > > ones that I've run into so far. > > What does this fix? It fixes insane scenarios like this, which was previously in dump.h: # include /* resolve xfs_dinode and xfs_sb deps */ # include "xfs_inum.h" /* resolve xfs_dinode and xfs_sb deps */ # include "xfs_types.h" /* resolve xfs_attr_sf, xfs_bmap_btree, and xfs_dir_sf deps */ # include "xfs_buf.h" /* resolve xfs_bmap_btree dep */ # include "xfs_bmap_btree.h" /* resolve xfs_dinode dep */ # include "xfs_dir_sf.h" /* resolve xfs_attr_sf dep */ # include "xfs_attr_sf.h" /* resolve xfs_dinode dep */ # include "xfs_dir2_sf.h" /* resolve xfs_dinode dep */ # include "xfs_dinode.h" /* resolve xfs_sb dep */ # include "xfs_sb.h" /* resolve xfs_mount dep */ # include "ksys/behavior.h" /* resolve xfs_mount dep */ # include "xfs_log.h" /* resolve xfs_trans dep */ # include "xfs_trans.h" /* resolve xfs_mount dep */ # include "xfs_dir.h" /* resolve xfs_mount dep */ #include "xfs_mount.h" /* for xfs_mount_t */ > The rest shouldn't really matter, as long as it doesn't break either > one of the build paths. By this do you mean the module and non-module build path, or the native and non-native build path, or the delalloc and non-delalloc build path...? -Phil