Received: with ECARTIS (v1.0.0; list netdev); Tue, 12 Jul 2005 14:05:58 -0700 (PDT)
Received: from sunset.davemloft.net (dsl027-180-168.sfo1.dsl.speakeasy.net [216.27.180.168])
	by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id j6CL5sH9000376
	for <netdev@oss.sgi.com>; Tue, 12 Jul 2005 14:05:54 -0700
Received: from localhost ([127.0.0.1] ident=davem)
	by sunset.davemloft.net with esmtp (Exim 4.50)
	id 1DsRvH-00045x-Im; Tue, 12 Jul 2005 14:04:11 -0700
Date: Tue, 12 Jul 2005 14:04:11 -0700 (PDT)
Message-Id: <20050712.140411.41107257.davem@davemloft.net>
To: ravinandan.arakali@neterion.com
Cc: hch@infradead.org, raghavendra.koushik@neterion.com, jgarzik@pobox.com,
        netdev@oss.sgi.com, leonid.grossman@neterion.com,
        rapuru.sriram@neterion.com
Subject: Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements
From: "David S. Miller" <davem@davemloft.net>
In-Reply-To: <000a01c58724$ca41a7c0$4f10100a@pc.s2io.com>
References: <20050712.133404.52118192.davem@davemloft.net>
	<000a01c58724$ca41a7c0$4f10100a@pc.s2io.com>
X-Mailer: Mew version 4.2 on Emacs 21.4 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-archive-position: 2722
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: davem@davemloft.net
Precedence: bulk
X-list: netdev
Content-Length: 522
Lines: 13

From: "Ravinandan Arakali" <ravinandan.arakali@neterion.com>
Subject: RE: [PATCH 2.6.12.1 5/12] S2io: Performance improvements
Date: Tue, 12 Jul 2005 14:00:52 -0700

> The two-buffer mode was added as a configurable option
> to Kconfig file several months ago. Hence the macro
> is CONFIG_2BUFF_MODE.

We're saying that you should choose CONFIG_2BUFF_MODE, when
CONFIG_IA64_SGI_SN2 is set, inside the Kconfig file using the
"default" Kconfig directive.

You should never change the setting of CONFIG_* macros in C source.