Received: with ECARTIS (v1.0.0; list netdev); Tue, 12 Jul 2005 13:35:52 -0700 (PDT)
Received: from sunset.davemloft.net (dsl027-180-168.sfo1.dsl.speakeasy.net [216.27.180.168])
	by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id j6CKZkH9029750
	for <netdev@oss.sgi.com>; Tue, 12 Jul 2005 13:35:46 -0700
Received: from localhost ([127.0.0.1] ident=davem)
	by sunset.davemloft.net with esmtp (Exim 4.50)
	id 1DsRS8-0001uM-7r; Tue, 12 Jul 2005 13:34:04 -0700
Date: Tue, 12 Jul 2005 13:34:04 -0700 (PDT)
Message-Id: <20050712.133404.52118192.davem@davemloft.net>
To: hch@infradead.org
Cc: raghavendra.koushik@neterion.com, jgarzik@pobox.com, netdev@oss.sgi.com,
        ravinandan.arakali@neterion.com, leonid.grossman@neterion.com,
        rapuru.sriram@neterion.com
Subject: Re: [PATCH 2.6.12.1 5/12] S2io: Performance improvements
From: "David S. Miller" <davem@davemloft.net>
In-Reply-To: <20050712202754.GA10768@infradead.org>
References: <20050707222741.71C3E89826@linux.site>
	<20050712202754.GA10768@infradead.org>
X-Mailer: Mew version 4.2 on Emacs 21.4 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-archive-position: 2719
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: davem@davemloft.net
Precedence: bulk
X-list: netdev
Content-Length: 458
Lines: 13

From: Christoph Hellwig <hch@infradead.org>
Date: Tue, 12 Jul 2005 21:27:54 +0100

> > +/* Enable 2 buffer mode by default for SGI system */
> > +#ifdef CONFIG_IA64_SGI_SN2
> > +#define CONFIG_2BUFF_MODE
> > +#endif
> 
> this enabled it only on kernel that are built to only run on SN2
> hardware, which is completely useless in practice.  Besides that defining
> a CONFIG_ symbol from source files is a big no-go.

Yes, do this in the Kconfig file instead.