Received: with ECARTIS (v1.0.0; list netdev); Sun, 15 May 2005 01:02:08 -0700 (PDT) Received: from arnor.apana.org.au (arnor.apana.org.au [203.14.152.115]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id j4F820Ov007501 for ; Sun, 15 May 2005 01:02:01 -0700 Received: from gondolin.me.apana.org.au ([192.168.0.6] ident=mail) by arnor.apana.org.au with esmtp (Exim 3.35 #1 (Debian)) id 1DXE3q-0003p7-00; Sun, 15 May 2005 18:01:18 +1000 Received: from herbert by gondolin.me.apana.org.au with local (Exim 3.36 #1 (Debian)) id 1DXE3h-0002jR-00; Sun, 15 May 2005 18:01:09 +1000 From: Herbert Xu To: johnpol@2ka.mipt.ru (Evgeniy Polyakov) Subject: Re: [1/1] xfrm: skb_cow_data() does not set proper owner for new skbs. Cc: netdev@oss.sgi.com, davem@davemloft.net Organization: Core In-Reply-To: <20050514134834.GA2698@uganda.factory.vocord.ru> X-Newsgroups: apana.lists.os.linux.netdev User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686)) Message-Id: Date: Sun, 15 May 2005 18:01:09 +1000 X-archive-position: 1134 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: herbert@gondor.apana.org.au Precedence: bulk X-list: netdev Content-Length: 963 Lines: 26 Evgeniy Polyakov wrote: > > As far as I can see, current code sets destructor and socket > for the first one skb only and uses truesize of the first skb > only to increment sk_wmem_alloc value. > > If above "analysis" is correct then attached patch fixes that. Yes you're absolutely right. > Signed-off-by: Evgeniy Polyakov Acked-by: Herbert Xu In fact you've uncovered a couple of bugs elsewhere too. IPv4's ip_push_pending_frames attributes all the data to the first skb which breaks when the packet is sent through ip_fragment since the latter does not undo the truesize attribution. skb_linearize is broken as well since it ignores truesize/owner altogether. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt