Received: with ECARTIS (v1.0.0; list netdev); Sun, 15 May 2005 18:01:52 -0700 (PDT) Received: from arnor.apana.org.au (arnor.apana.org.au [203.14.152.115]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id j4G11jOv032177 for ; Sun, 15 May 2005 18:01:46 -0700 Received: from gondolin.me.apana.org.au ([192.168.0.6] ident=mail) by arnor.apana.org.au with esmtp (Exim 3.35 #1 (Debian)) id 1DXTye-00011p-00; Mon, 16 May 2005 11:01:00 +1000 Received: from herbert by gondolin.me.apana.org.au with local (Exim 3.36 #1 (Debian)) id 1DXTyc-0005OT-00; Mon, 16 May 2005 11:00:58 +1000 Date: Mon, 16 May 2005 11:00:58 +1000 To: "David S. Miller" Cc: johnpol@2ka.mipt.ru, netdev@oss.sgi.com Subject: Re: [IPV4/IPV6] Keep wmem accounting separate in ip*_push_pending_frames Message-ID: <20050516010058.GA20704@gondor.apana.org.au> References: <20050515.152441.106262257.davem@davemloft.net> <20050515232020.GA19859@gondor.apana.org.au> <20050515235913.GA20242@gondor.apana.org.au> <20050515.173944.122590923.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050515.173944.122590923.davem@davemloft.net> User-Agent: Mutt/1.5.6+20040907i From: Herbert Xu X-archive-position: 1165 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: herbert@gondor.apana.org.au Precedence: bulk X-list: netdev Content-Length: 585 Lines: 17 On Sun, May 15, 2005 at 05:39:44PM -0700, David S. Miller wrote: > > This code should therefore just skb_orphan(), and nothing > more. Right? Ideally we should move the ownership to the head skb here as well. However, doing this would cause havoc when you have nasty users sending fragments from two different sockets :) So let's stick with just the skb_orphan. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt