Received: with ECARTIS (v1.0.0; list netdev); Sun, 15 May 2005 17:00:09 -0700 (PDT) Received: from arnor.apana.org.au (arnor.apana.org.au [203.14.152.115]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id j4G003Ov029117 for ; Sun, 15 May 2005 17:00:04 -0700 Received: from gondolin.me.apana.org.au ([192.168.0.6] ident=mail) by arnor.apana.org.au with esmtp (Exim 3.35 #1 (Debian)) id 1DXT0t-0000mz-00; Mon, 16 May 2005 09:59:15 +1000 Received: from herbert by gondolin.me.apana.org.au with local (Exim 3.36 #1 (Debian)) id 1DXT0r-0005H2-00; Mon, 16 May 2005 09:59:13 +1000 Date: Mon, 16 May 2005 09:59:13 +1000 To: "David S. Miller" Cc: johnpol@2ka.mipt.ru, netdev@oss.sgi.com Subject: Re: [IPV4/IPV6] Keep wmem accounting separate in ip*_push_pending_frames Message-ID: <20050515235913.GA20242@gondor.apana.org.au> References: <20050515104016.GA24344@gondor.apana.org.au> <20050515114121.GA4830@gondor.apana.org.au> <20050515.152441.106262257.davem@davemloft.net> <20050515232020.GA19859@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050515232020.GA19859@gondor.apana.org.au> User-Agent: Mutt/1.5.6+20040907i From: Herbert Xu X-archive-position: 1162 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: herbert@gondor.apana.org.au Precedence: bulk X-list: netdev Content-Length: 806 Lines: 22 On Mon, May 16, 2005 at 09:20:20AM +1000, herbert wrote: > > BTW, I missed the netfilter defrag code in my patch. I'll send an > updated version soon. Actually that turns out to be OK since ip_ct_gather_frags zeros the skb->sk field before feeding it to ip_defrag. Once the packet has been reassembled it tries to put the sk back which fails unless the head skb comes in last which is never the case on the output path. Although the second part is buggy, it does not violate the invariant I stated before. Please let me know if you still have any questions/problems with my patch. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt