Received: with ECARTIS (v1.0.0; list netdev); Sun, 15 May 2005 14:30:30 -0700 (PDT) Received: from arnor.apana.org.au (arnor.apana.org.au [203.14.152.115]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id j4FLUOOv015509 for ; Sun, 15 May 2005 14:30:26 -0700 Received: from gondolin.me.apana.org.au ([192.168.0.6] ident=mail) by arnor.apana.org.au with esmtp (Exim 3.35 #1 (Debian)) id 1DXQgD-0008Th-00; Mon, 16 May 2005 07:29:45 +1000 Received: from herbert by gondolin.me.apana.org.au with local (Exim 3.36 #1 (Debian)) id 1DXQgA-00051S-00; Mon, 16 May 2005 07:29:42 +1000 Date: Mon, 16 May 2005 07:29:42 +1000 To: Evgeniy Polyakov Cc: netdev@oss.sgi.com, davem@davemloft.net Subject: Re: [IPV4/IPV6] Ensure all frag_list members have NULL sk Message-ID: <20050515212942.GA19296@gondor.apana.org.au> References: <20050514134834.GA2698@uganda.factory.vocord.ru> <20050515104016.GA24344@gondor.apana.org.au> <20050515114121.GA4830@gondor.apana.org.au> <20050515122256.GA22251@gondor.apana.org.au> <20050515213341.4011c00e@zanzibar.2ka.mipt.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050515213341.4011c00e@zanzibar.2ka.mipt.ru> User-Agent: Mutt/1.5.6+20040907i From: Herbert Xu X-archive-position: 1148 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: herbert@gondor.apana.org.au Precedence: bulk X-list: netdev Content-Length: 720 Lines: 20 On Sun, May 15, 2005 at 09:33:41PM +0400, Evgeniy Polyakov wrote: > > > So let's go the other way and make this an invariant: > > > > For any skb on a frag_list, skb->sk must be NULL. > > This requires skb_set_owner_* to check if it is called > for head skb or one from fragment and does nothing if > it is from frag_list. > Or to check the whole tree for ownering calls... Not really. The frag_list skb's owned by sk's are generated in one place only, and that place is ip*_push_pending_frames. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt