Received: with ECARTIS (v1.0.0; list netdev); Sun, 15 May 2005 17:40:33 -0700 (PDT)
Received: from sunset.davemloft.net (dsl027-180-168.sfo1.dsl.speakeasy.net [216.27.180.168])
	by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id j4G0eUOv031157
	for <netdev@oss.sgi.com>; Sun, 15 May 2005 17:40:30 -0700
Received: from localhost ([127.0.0.1] ident=davem)
	by sunset.davemloft.net with esmtp (Exim 4.50)
	id 1DXTe4-000451-Mz; Sun, 15 May 2005 17:39:44 -0700
Date: Sun, 15 May 2005 17:39:44 -0700 (PDT)
Message-Id: <20050515.173944.122590923.davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: johnpol@2ka.mipt.ru, netdev@oss.sgi.com
Subject: Re: [IPV4/IPV6] Keep wmem accounting separate in
 ip*_push_pending_frames
From: "David S. Miller" <davem@davemloft.net>
In-Reply-To: <20050515235913.GA20242@gondor.apana.org.au>
References: <20050515.152441.106262257.davem@davemloft.net>
	<20050515232020.GA19859@gondor.apana.org.au>
	<20050515235913.GA20242@gondor.apana.org.au>
X-Mailer: Mew version 3.3 on Emacs 21.4 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-archive-position: 1164
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: davem@davemloft.net
Precedence: bulk
X-list: netdev
Content-Length: 530
Lines: 13

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 16 May 2005 09:59:13 +1000

> Actually that turns out to be OK since ip_ct_gather_frags zeros the
> skb->sk field before feeding it to ip_defrag.  Once the packet has
> been reassembled it tries to put the sk back which fails unless the
> head skb comes in last which is never the case on the output path.
> 
> Although the second part is buggy, it does not violate the invariant
> I stated before.

This code should therefore just skb_orphan(), and nothing
more.  Right?