Received: with ECARTIS (v1.0.0; list netdev); Sat, 07 May 2005 06:09:36 -0700 (PDT) Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id j47D9XOv012897 for ; Sat, 7 May 2005 06:09:34 -0700 Received: from g133107.upc-g.chello.nl ([80.57.133.107] helo=[172.31.3.43]) by pentafluge.infradead.org with esmtpsa (Exim 4.43 #1 (Red Hat Linux)) id 1DUP3H-0005sw-LI; Sat, 07 May 2005 14:09:04 +0100 Subject: Re: [2.6 patch] drivers/net/ixgb/: possible cleanups From: Arjan van de Ven To: Adrian Bunk Cc: Ganesh Venkatesan , ayyappan.veeraiyan@intel.com, ganesh.venkatesan@intel.com, john.ronciak@intel.com, jgarzik@pobox.com, netdev@oss.sgi.com, linux-kernel@vger.kernel.org In-Reply-To: <20050507123814.GJ3590@stusta.de> References: <20050506211834.GM3590@stusta.de> <5fc59ff3050506153523cd12dd@mail.gmail.com> <1115468645.6388.37.camel@laptopd505.fenrus.org> <20050507123814.GJ3590@stusta.de> Content-Type: text/plain Date: Sat, 07 May 2005 15:09:01 +0200 Message-Id: <1115471341.6388.41.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 (2.0.4-4) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html X-archive-position: 926 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: arjan@infradead.org Precedence: bulk X-list: netdev Content-Length: 280 Lines: 9 > I'm not sure whether Ganesh was really talking about license issues, or > whether the problem is that my patch #if 0's away code they use in other > non-GPL'ed drivers. fair point, the solution for the later could be to use #ifndef __linux__ or something instead of #if 0