Received: with ECARTIS (v1.0.0; list netdev); Sat, 07 May 2005 05:04:44 -0700 (PDT)
Received: from mx04.cybersurf.com (mx04.cybersurf.com [209.197.145.108])
	by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id j47C4eOv005688
	for <netdev@oss.sgi.com>; Sat, 7 May 2005 05:04:41 -0700
Received: from mail.cyberus.ca ([209.197.145.21])
	by mx04.cybersurf.com with esmtp (Exim 4.30)
	id 1DUO2i-0003R3-0a
	for netdev@oss.sgi.com; Sat, 07 May 2005 08:04:24 -0400
Received: from cpe0030ab124d2f-cm014500000962.cpe.net.cable.rogers.com ([24.103.99.32] helo=[10.0.0.229])
	by mail.cyberus.ca with esmtp (Exim 4.20)
	id 1DUO2e-0005GJ-IU; Sat, 07 May 2005 08:04:20 -0400
Subject: Re: [7/7] [IPSEC] Add XFRMA_SA/XFRMA_POLICY for delete notification
From: jamal <hadi@cyberus.ca>
Reply-To: hadi@cyberus.ca
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
        Masahide NAKAMURA <nakam@linux-ipv6.org>,
        Patrick McHardy <kaber@trash.net>, netdev <netdev@oss.sgi.com>
In-Reply-To: <20050507072349.GH5753@gondor.apana.org.au>
References: <1112702604.1089.119.camel@jzny.localdomain>
	 <20050409105452.GA7171@gondor.apana.org.au>
	 <20050507071434.GA5716@gondor.apana.org.au>
	 <20050507071824.GA5753@gondor.apana.org.au>
	 <20050507071930.GC5753@gondor.apana.org.au>
	 <20050507072058.GD5753@gondor.apana.org.au>
	 <20050507072139.GE5753@gondor.apana.org.au>
	 <20050507072216.GF5753@gondor.apana.org.au>
	 <20050507072251.GG5753@gondor.apana.org.au>
	 <20050507072349.GH5753@gondor.apana.org.au>
Content-Type: text/plain
Organization: unknown
Date: Sat, 07 May 2005 08:04:16 -0400
Message-Id: <1115467457.19561.5.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.2.1.1 
Content-Transfer-Encoding: 7bit
X-archive-position: 917
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: hadi@cyberus.ca
Precedence: bulk
X-list: netdev
Content-Length: 934
Lines: 26

On Sat, 2005-07-05 at 17:23 +1000, Herbert Xu wrote:
> Hi:
> 
> This patch changes the format of the XFRM_MSG_DELSA and
> XFRM_MSG_DELPOLICY notification so that the main message
> sent is of the same format as that received by the kernel
> if the original message was via netlink.  This also means
> that we won't lose the byid information carried in km_event.
> 

This is incosistent in two ways:
1) Typical netlink behavior is to return the object being deleted.
Every other netlink user behaves that way - the only exception is sone
filters in tc and this is because they cant retrieve that detail
(something that needs resolution at some point). There is nothing that
xfrm_usersa_id provides that can be found in xfrm_usersa_info.
Same for the policy.

2) You cant have one behavior when something is deleted by pfkey and a
different one when it is deleted by netlink.

So i would recommend pulling this one out.

cheers,
jamal