Received: with ECARTIS (v1.0.0; list netdev); Sun, 10 Apr 2005 14:29:26 -0700 (PDT) Received: from arnor.apana.org.au (mail@arnor.apana.org.au [203.14.152.115]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j3ALTG7R011853 for ; Sun, 10 Apr 2005 14:29:16 -0700 Received: from gondolin.me.apana.org.au ([192.168.0.6] ident=mail) by arnor.apana.org.au with esmtp (Exim 3.35 #1 (Debian)) id 1DKjzG-0006Rl-00; Mon, 11 Apr 2005 07:28:58 +1000 Received: from herbert by gondolin.me.apana.org.au with local (Exim 3.36 #1 (Debian)) id 1DKjz6-0007tz-00; Mon, 11 Apr 2005 07:28:48 +1000 Date: Mon, 11 Apr 2005 07:28:48 +1000 To: jamal Cc: "David S. Miller" , Masahide NAKAMURA , Patrick McHardy , netdev Subject: Re: [5/*] [IPSEC] Use XFRM_MSG_* instead of XFRM_SAP_* Message-ID: <20050410212848.GB30337@gondor.apana.org.au> References: <1112702604.1089.119.camel@jzny.localdomain> <20050409105452.GA7171@gondor.apana.org.au> <20050409111244.GB7171@gondor.apana.org.au> <20050409111551.GA7378@gondor.apana.org.au> <20050410074849.GA13259@gondor.apana.org.au> <20050410090250.GA26022@gondor.apana.org.au> <1113142510.1091.294.camel@jzny.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1113142510.1091.294.camel@jzny.localdomain> User-Agent: Mutt/1.5.6+20040907i From: Herbert Xu X-Virus-Scanned: ClamAV 0.83/816/Fri Apr 8 17:46:45 2005 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 1649 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: herbert@gondor.apana.org.au Precedence: bulk X-list: netdev Content-Length: 840 Lines: 22 On Sun, Apr 10, 2005 at 10:15:11AM -0400, jamal wrote: > > The main reason i did the XFRM_SAP_* is to be able to cover a case where > a message was relevant to one KM but not the other. That may not > exist now (actually it does with policy expiration that pfkey cant > handle - but thats easy to take care of). > Hopefully XFRM_MSG_xxx is the superset and will be sufficient. Since xfrm_user is meant to be the native interface, this should never happen. > Do you have anymore patches? If not i can give these a quick test; > Masahide has a better test setup and if he has time he should as well. That's it for now. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt