Received: with ECARTIS (v1.0.0; list netdev); Wed, 09 Mar 2005 15:16:06 -0800 (PST) Received: from smtp.osdl.org (fire.osdl.org [65.172.181.4]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j29NG1YX002078 for ; Wed, 9 Mar 2005 15:16:01 -0800 Received: from shell0.pdx.osdl.net (fw.osdl.org [65.172.181.6]) by smtp.osdl.org (8.12.8/8.12.8) with ESMTP id j29NFrqi006202 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Wed, 9 Mar 2005 15:15:53 -0800 Received: from dxpl.pdx.osdl.net (dxpl.pdx.osdl.net [172.20.1.103]) by shell0.pdx.osdl.net (8.13.1/8.11.6) with ESMTP id j29NFrEo028569; Wed, 9 Mar 2005 15:15:53 -0800 Date: Wed, 9 Mar 2005 15:16:11 -0800 From: Stephen Hemminger To: Francois Romieu Cc: netdev@oss.sgi.com Subject: Re: [PATCH 1/5] r8169: auto detect 32-bit slot Message-ID: <20050309151611.431accce@dxpl.pdx.osdl.net> In-Reply-To: <20050309230809.GC9502@electric-eye.fr.zoreil.com> References: <20050309112925.7f7900ab@dxpl.pdx.osdl.net> <20050309214023.GA9502@electric-eye.fr.zoreil.com> <20050309135530.5c5c80b6@dxpl.pdx.osdl.net> <20050309230809.GC9502@electric-eye.fr.zoreil.com> Organization: Open Source Development Lab X-Mailer: Sylpheed-Claws 1.0.1 (GTK+ 1.2.10; x86_64-unknown-linux-gnu) X-Face: &@E+xe?c%:&e4D{>f1O<&U>2qwRREG5!}7R4;D<"NO^UI2mJ[eEOA2*3>(`Th.yP,VDPo9$ /`~cw![cmj~~jWe?AHY7D1S+\}5brN0k*NE?pPh_'_d>6;XGG[\KDRViCfumZT3@[ Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass (domain of shemminger@osdl.org designates 65.172.181.6 as permitted sender) X-MIMEDefang-Filter: osdl$Revision: 1.104 $ X-Scanned-By: MIMEDefang 2.36 X-Virus-Scanned: ClamAV 0.83/757/Tue Mar 8 15:14:36 2005 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 2778 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: shemminger@osdl.org Precedence: bulk X-list: netdev Content-Length: 1435 Lines: 30 On Thu, 10 Mar 2005 00:08:09 +0100 Francois Romieu wrote: > Stephen Hemminger : > [...] > > I tested on old Celeron with Netgear card. I could try Amd and/or Xeon > > if you want. > > If the systems are 64 bit, one would need to know how the driver behaves > when DAC is forced and: > 1) the Netgear card is in a 32 bit slot, dma to highmem is enabled and used > 2) the Netgear card is in a 32 bit slot, dma to highmem is enabled and unused > 3) the Netgear card is in a 32 bit slot, dma to highmem is disabled > 4) the Netgear card is in a 64 bit slot, dma to highmem is enabled and used > 5) the Netgear card is in a 64 bit slot, dma to highmem is enabled and unused > 6) the Netgear card is in a 64 bit slot, dma to highmem is disabled > > + the content of the Config2 register for 1-6. > > If the amd64 hosts a built-in 8169, add the behavior with highmem disabled or > enabled + variable amount of memory. > > As it still leaves some archs in the cold + DAC ought not to be dependant > on the bus width + a few "broken" adapters exist, the patch makes me a bit > sceptical. Okay, the motivation was to try and get rid of the module parameter. I hate to see more parameters, and really don't like it when different drivers start to do things in different ways. Don't really have enough background to know which adapters and arch combinations are broken; so just drop the patch.