Received: with ECARTIS (v1.0.0; list netdev); Mon, 07 Mar 2005 09:14:53 -0800 (PST) Received: from ruslug.rutgers.edu (ruslug.rutgers.edu [128.6.24.131]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j27HEi8k021769 for ; Mon, 7 Mar 2005 09:14:45 -0800 Received: by ruslug.rutgers.edu (Postfix, from userid 503) id 93920F9D94; Mon, 7 Mar 2005 12:14:44 -0500 (EST) Date: Mon, 7 Mar 2005 12:14:44 -0500 To: domen@coderock.org Cc: prism54-private@prism54.org, netdev@oss.sgi.com, c.lucas@ifrance.com Subject: Re: [patch 3/3] drivers/net/wireless/prism54/*: convert to pci_register_driver Message-ID: <20050307171444.GU3936@ruslug.rutgers.edu> Mail-Followup-To: domen@coderock.org, prism54-private@prism54.org, netdev@oss.sgi.com, c.lucas@ifrance.com References: <20050306222358.752961EC90@trashy.coderock.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050306222358.752961EC90@trashy.coderock.org> User-Agent: Mutt/1.3.28i X-Operating-System: 2.4.18-1-686 Organization: Rutgers University Student Linux Users Group From: mcgrof@ruslug.rutgers.edu (Luis R. Rodriguez) X-Virus-Scanned: ClamAV 0.83/751/Mon Mar 7 03:06:27 2005 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 2592 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: mcgrof@ruslug.rutgers.edu Precedence: bulk X-list: netdev Content-Length: 1190 Lines: 31 On Sun, Mar 06, 2005 at 11:23:58PM +0100, domen@coderock.org wrote: > > convert from pci_module_init to pci_register_driver > (from:http://kerneljanitors.org/TODO). > > Signed-off-by: Christophe Lucas > Signed-off-by: Domen Puncer > --- > > > kj-domen/drivers/net/wireless/prism54/islpci_hotplug.c | 2 +- > 1 files changed, 1 insertion(+), 1 deletion(-) > > diff -puN drivers/net/wireless/prism54/islpci_hotplug.c~pci_register_driver-drivers_net_wireless_prism54 drivers/net/wireless/prism54/islpci_hotplug.c > --- kj/drivers/net/wireless/prism54/islpci_hotplug.c~pci_register_driver-drivers_net_wireless_prism54 2005-03-05 16:12:44.000000000 +0100 > +++ kj-domen/drivers/net/wireless/prism54/islpci_hotplug.c 2005-03-05 16:12:44.000000000 +0100 > @@ -315,7 +315,7 @@ prism54_module_init(void) > > __bug_on_wrong_struct_sizes (); > > - return pci_module_init(&prism54_driver); > + return pci_register_driver(&prism54_driver); > } > > /* by the time prism54_module_exit() terminates, as a postcondition > _ How about this one? Is this 2.4 compat? -- GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84 A34A 6ADD 4937 E20A 525E