Received: with ECARTIS (v1.0.0; list netdev); Thu, 03 Mar 2005 13:34:03 -0800 (PST) Received: from bastet.signetmail.com (atlmail.prod.rxgsys.com [64.74.124.160]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j23LXxS7014431 for ; Thu, 3 Mar 2005 13:33:59 -0800 Received: from localhost (localhost.localdomain [127.0.0.1]) by bastet.signetmail.com (RXG Elite Mail Server) with ESMTP id B6EBFA87A3; Thu, 3 Mar 2005 16:28:29 -0500 (EST) Received: from bastet.signetmail.com ([127.0.0.1]) by localhost (atlmail.prod.rxgsys.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 18031-04; Thu, 3 Mar 2005 16:28:25 -0500 (EST) Received: from havoc.gtf.org (havoc.gtf.org [63.115.148.101]) by bastet.signetmail.com (RXG Elite Mail Server) with ESMTP id 48588A87A0; Thu, 3 Mar 2005 16:28:22 -0500 (EST) Received: from havoc.gtf.org (havoc.gtf.org [127.0.0.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by havoc.gtf.org (Postfix) with ESMTP id 4E08E1C0A858; Thu, 3 Mar 2005 16:33:42 -0500 (EST) Received: (from garzik@localhost) by havoc.gtf.org (8.13.1/8.13.1/Submit) id j23LXfXh021149; Thu, 3 Mar 2005 16:33:41 -0500 Date: Thu, 3 Mar 2005 16:33:41 -0500 From: Jeff Garzik To: "David S. Miller" Cc: mpm@selenic.com, netdev@oss.sgi.com, jmoyer@redhat.com Subject: Re: [PATCH 7/7] netpoll: avoid kfree_skb on packets with destructo Message-ID: <20050303213341.GA21135@havoc.gtf.org> References: <7.454130102@selenic.com> <8.454130102@selenic.com> <20050303130031.066f0862.davem@davemloft.net> <42277ED6.4020707@pobox.com> <20050303132906.2b5d597f.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050303132906.2b5d597f.davem@davemloft.net> User-Agent: Mutt/1.4.1i X-Virus-Scanned: ClamAV 0.83/743/Wed Mar 2 16:02:05 2005 on oss.sgi.com X-Virus-Scanned: by EMS at localhost.localdomain X-Virus-Status: Clean X-archive-position: 2333 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: jgarzik@pobox.com Precedence: bulk X-list: netdev On Thu, Mar 03, 2005 at 01:29:06PM -0800, David S. Miller wrote: > On Thu, 03 Mar 2005 16:17:10 -0500 > Jeff Garzik wrote: > > > Heh, I was just writing this same message. > > > > On a related note... David, I would prefer if you merged up the netpoll > > stuff, since it touches mainly net/* > > > > Is that cool w/ you? > > No problem. I still don't like this code in that it adds a locking > penalty to everyone just by virtue of enabling netpoll. We've worked > so hard with things like NETIF_F_LLTX to eliminate locking, so this > would be a huge step backwards. Agreed. Jeff