Received: with ECARTIS (v1.0.0; list netdev); Sat, 19 Feb 2005 10:56:16 -0800 (PST)
Received: from kaber.coreworks.de ([62.206.217.67])
	by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j1JIuCSB032109
	for <netdev@oss.sgi.com>; Sat, 19 Feb 2005 10:56:12 -0800
Received: from localhost ([127.0.0.1])
	by kaber.coreworks.de with esmtp (Exim 4.44)
	id 1D2ZlQ-0001MP-61; Sat, 19 Feb 2005 19:55:36 +0100
Message-ID: <42178BA8.4090305@trash.net>
Date: Sat, 19 Feb 2005 19:55:36 +0100
From: Patrick McHardy <kaber@trash.net>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.5) Gecko/20050106 Debian/1.7.5-1
X-Accept-Language: en
MIME-Version: 1.0
To: Herbert Xu <herbert@gondor.apana.org.au>
CC: "David S. Miller" <davem@davemloft.net>,
        Maillist netdev <netdev@oss.sgi.com>
Subject: Re: [XFRM]: Fix ICMP tempsel
References: <4217266F.6090700@trash.net> <20050219184351.GB10773@gondor.apana.org.au>
In-Reply-To: <20050219184351.GB10773@gondor.apana.org.au>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV version 0.81, clamav-milter version 0.81b on oss.sgi.com
X-Virus-Status: Clean
X-archive-position: 1820
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: kaber@trash.net
Precedence: bulk
X-list: netdev
Content-Length: 382
Lines: 20

Herbert Xu wrote:

>I know this comment is probably a bit late but why didn't we simply put
>type/code into sport/dport in struct flowi instead of introducing the
>monstrosities of xfrm_flowi_sport/xfrm_flowi_dport?
>
>Something like
>
>struct {
>	__u16	type;
>	__u16	code;
>} icmpt;
>
>would've done (and still would do) the trick, no?
>
I agree, that is better.

Regards
Patrick