Received: with ECARTIS (v1.0.0; list netdev); Tue, 15 Feb 2005 14:44:31 -0800 (PST) Received: from cheetah.davemloft.net (mail@adsl-63-197-226-105.dsl.snfc21.pacbell.net [63.197.226.105]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j1FMiP0A016220 for ; Tue, 15 Feb 2005 14:44:26 -0800 Received: from localhost ([127.0.0.1] helo=cheetah.davemloft.net ident=davem) by cheetah.davemloft.net with smtp (Exim 3.36 #1 (Debian)) id 1D1BNi-0007he-00; Tue, 15 Feb 2005 14:41:22 -0800 Date: Tue, 15 Feb 2005 14:41:21 -0800 From: "David S. Miller" To: Herbert Xu Cc: yoshfuji@linux-ipv6.org, netdev@oss.sgi.com Subject: Re: [IPV4] Make loopback idev stick around Message-Id: <20050215144121.702767c5.davem@davemloft.net> In-Reply-To: <20050205053532.GA17474@gondor.apana.org.au> References: <20050205053030.GA17412@gondor.apana.org.au> <20050205053532.GA17474@gondor.apana.org.au> X-Mailer: Sylpheed version 1.0.1 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.81, clamav-milter version 0.81b on oss.sgi.com X-Virus-Status: Clean X-archive-position: 1695 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: davem@davemloft.net Precedence: bulk X-list: netdev Content-Length: 689 Lines: 19 On Sat, 5 Feb 2005 16:35:32 +1100 Herbert Xu wrote: > On Sat, Feb 05, 2005 at 04:30:30PM +1100, herbert wrote: > > > > As it is when loopback_dev loses all of its IPv4 addresses its > > corresponding idev will be destroyed. Unfortunately as of last > > August route.c relies on the loopback idev to kill references > > to other idev objects. > > The same problem exists for IPv6. > > Signed-off-by: Herbert Xu Both patches applied to the 2.6.12-pending tree. I wish ->notifier_call()'s value was actually checked, we could do intelligent things instead of panic()'ing when (for example) loopback's idev allocation fails.