Received: with ECARTIS (v1.0.0; list netdev); Tue, 25 Jan 2005 03:57:58 -0800 (PST) Received: from arnor.apana.org.au (mail@arnor.apana.org.au [203.14.152.115]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j0PBvn5U006117 for ; Tue, 25 Jan 2005 03:57:50 -0800 Received: from gondolin.me.apana.org.au ([192.168.0.6] ident=mail) by arnor.apana.org.au with esmtp (Exim 3.35 #1 (Debian)) id 1CtPK7-0003Ig-00; Tue, 25 Jan 2005 22:57:31 +1100 Received: from herbert by gondolin.me.apana.org.au with local (Exim 3.36 #1 (Debian)) id 1CtPJf-0005RG-00; Tue, 25 Jan 2005 22:57:03 +1100 From: Herbert Xu To: kaber@trash.net (Patrick McHardy) Subject: Re: [PATCH 2.6]: keep fragment queues private to each user Cc: davem@davemloft.net, netdev@oss.sgi.com Organization: Core In-Reply-To: <41F5D1CB.9050804@trash.net> X-Newsgroups: apana.lists.os.linux.netdev User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686)) Message-Id: Date: Tue, 25 Jan 2005 22:57:03 +1100 X-Virus-Scanned: ClamAV 0.80/650/Sun Jan 2 19:00:02 2005 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 757 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: herbert@gondor.apana.org.au Precedence: bulk X-list: netdev Content-Length: 756 Lines: 20 Patrick McHardy wrote: > > This patch keeps fragment queues private to each ip_defrag user to avoid > skbs jumping between different callers. It shouldn't change any wanted > behaviour, the only questionable one was ip_call_ra_chain, but the RA > option is included in each fragment. If you're fine with the patch I'm going > to send a 2.4 version later. Patch looks good. However, I think this is still not enough. What about fragments that come from different interfaces? Fragments with different security paths? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt