Received: with ECARTIS (v1.0.0; list netdev); Mon, 31 Jan 2005 06:57:24 -0800 (PST) Received: from dgate1.fujitsu-siemens.com (dgate1.fujitsu-siemens.com [217.115.66.35]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j0VEvGKv026556 for ; Mon, 31 Jan 2005 06:57:17 -0800 Received: from trulli.pdb.fsc.net (172.25.96.20) by dgate1.fujitsu-siemens.com with ESMTP; 31 Jan 2005 15:57:12 +0100 X-SBRSScore: None X-IronPort-AV: i="3.88,167,1102287600"; d="scan'208"; a="3863770:sNHT100830492" Received: from biker.psw.pdb.fsc.net (biker.pdb.fsc.net [172.25.253.106]) by trulli.pdb.fsc.net (8.11.6/8.11.6) with ESMTP id j0VEvBr05281; Mon, 31 Jan 2005 15:57:11 +0100 Received: from fujitsu-siemens.com (localhost [127.0.0.1]) by biker.psw.pdb.fsc.net (Postfix) with ESMTP id BDB41BC85; Mon, 31 Jan 2005 15:57:10 +0100 (CET) Message-ID: <41FE4745.4020003@fujitsu-siemens.com> Date: Mon, 31 Jan 2005 15:57:09 +0100 From: Martin Wilck Organization: Fujitsu Siemens Computers User-Agent: Mozilla Thunderbird 0.5 (X11/20040208) X-Accept-Language: de, en-us, en MIME-Version: 1.0 To: linux-kernel@vger.kernel.org, netdev@oss.sgi.com Subject: SIOCGIFMAP silently broken? Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.80/650/Sun Jan 2 19:00:02 2005 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 1090 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: martin.wilck@fujitsu-siemens.com Precedence: bulk X-list: netdev Content-Length: 1202 Lines: 32 Hi, we are using a server management software that uses the irq information returned by the SIOCGIFMAP ioctl to correlate network interfaces with LAN hardware. The code for SIOCGIFMAP if net/core/dev.c simply returns netdev->irq which isn't set by most actual LAN drivers any more, and it seems to be common opinion that setting netdev->irq is either optional or even wrong (http://www.ussg.iu.edu/hypermail/linux/kernel/0407.3/1292.html). Consequently, the SIOCGIFMAP ioctl reports bogus IRQ values for most hardware; it is therefore unreliable. Would it be possible to fix the ioctl such that it returns the correct irq value, e.g. be using the irq field of the associated struct pci_dev? If not, I'd consider it better to deprecate netdev->irq officially and always return bogus so that people stop using it. In both cases, the netdev->irq field isn't used anymore; perhaps it should be officially deprecated and/or removed? Regards Martin -- Martin Wilck Phone: +49 5251 8 15113 Fujitsu Siemens Computers Fax: +49 5251 8 20409 Heinz-Nixdorf-Ring 1 mailto:Martin.Wilck@Fujitsu-Siemens.com D-33106 Paderborn http://www.fujitsu-siemens.com/primergy