Received: with ECARTIS (v1.0.0; list netdev); Sun, 23 Jan 2005 16:56:52 -0800 (PST) Received: from kaber.coreworks.de ([62.206.217.67]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j0O0uld4002613 for ; Sun, 23 Jan 2005 16:56:48 -0800 Received: from localhost ([127.0.0.1]) by kaber.coreworks.de with esmtp (Exim 4.43) id 1CssX8-0000AQ-2I; Mon, 24 Jan 2005 01:56:46 +0100 Message-ID: <41F447CE.6030007@trash.net> Date: Mon, 24 Jan 2005 01:56:46 +0100 From: Patrick McHardy User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.5) Gecko/20050106 Debian/1.7.5-1 X-Accept-Language: en MIME-Version: 1.0 To: Thomas Graf CC: "David S. Miller" , netdev@oss.sgi.com Subject: Re: [PATCH 1/6] PKT_SCHED: Extended Matches API References: <20050123230012.GB23931@postel.suug.ch> <20050123230132.GC23931@postel.suug.ch> <41F43D6D.30502@trash.net> <20050124004929.GK23931@postel.suug.ch> In-Reply-To: <20050124004929.GK23931@postel.suug.ch> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.80/650/Sun Jan 2 19:00:02 2005 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 690 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: kaber@trash.net Precedence: bulk X-list: netdev Content-Length: 616 Lines: 20 Thomas Graf wrote: >* Patrick McHardy <41F43D6D.30502@trash.net> 2005-01-24 01:12 > > >>gcc assumes likely for ptr != NULL by default. Is there a reason why a match >>wouldn't have a match function ? >> > >There is no reason but ematches might get written by unexperienced people >forgeting to register it. I know, the if partly hides the failure, it's >one of theses case where I have the same arguments for both ways. > I don't care much, but I guess people forgetting to add a match function to an ematch will find other ways to do stupid things :) How about catching it in tcf_em_register ? Regards Patrick