Received: with ECARTIS (v1.0.0; list netdev); Sun, 23 Jan 2005 16:49:18 -0800 (PST) Received: from kaber.coreworks.de ([62.206.217.67]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j0O0nCKW000562 for ; Sun, 23 Jan 2005 16:49:13 -0800 Received: from localhost ([127.0.0.1]) by kaber.coreworks.de with esmtp (Exim 4.43) id 1CssPl-00008x-7D; Mon, 24 Jan 2005 01:49:09 +0100 Message-ID: <41F44605.6050001@trash.net> Date: Mon, 24 Jan 2005 01:49:09 +0100 From: Patrick McHardy User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.5) Gecko/20050106 Debian/1.7.5-1 X-Accept-Language: en MIME-Version: 1.0 To: Thomas Graf CC: David Coulson , netdev@oss.sgi.com Subject: Re: skb_checksum_help References: <41F432BD.3000300@davidcoulson.net> <20050124003241.GJ23931@postel.suug.ch> In-Reply-To: <20050124003241.GJ23931@postel.suug.ch> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.80/650/Sun Jan 2 19:00:02 2005 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 687 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: kaber@trash.net Precedence: bulk X-list: netdev Content-Length: 641 Lines: 25 Thomas Graf wrote: >I CC'ed netdev, this seems more serious than I thought. > >Background: David noticed the assertion csum + 2 > offset being trigged >in skb_checksum_help. I sent him a patch converting it into a warning >printing offset, len, n.raw, tail, csum, features and the whole packet >as hexdump. He uses the acenic driver which is actually capable of doing >IP checksumming. (Patch enclosed at the end) > How does the backtrace look ? >>skb hdr corrupted! >> > The check looks bogus: >+ if (skb->h.raw < skb->data || skb->h.raw > skb->data) >+ printk(KERN_CRIT "skb hdr corrupted!\n"); >+ goto out; >+ } > Regards Patrick