Received: with ECARTIS (v1.0.0; list netdev); Mon, 31 Jan 2005 02:31:32 -0800 (PST) Received: from koto.vergenet.net (koto.vergenet.net [210.128.90.7]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j0VAVPA3000494 for ; Mon, 31 Jan 2005 02:31:25 -0800 Received: by koto.vergenet.net (Postfix, from userid 7100) id BEE443421B; Mon, 31 Jan 2005 19:11:33 +0900 (JST) Date: Mon, 31 Jan 2005 13:21:12 +0300 From: Horms To: Andrew Morton Cc: davem@davemloft.net, netdev@oss.sgi.com Subject: Re: [patch 2/2] ipvs deadlock fix Message-ID: <20050131102111.GA6279@verge.net.au> Mail-Followup-To: Andrew Morton , davem@davemloft.net, netdev@oss.sgi.com References: <200501310633.j0V6X1l01385@mail.osdl.org> <20050131093609.GA3804@verge.net.au> <20050131014722.77d732c4.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050131014722.77d732c4.akpm@osdl.org> X-Cluestick: seven User-Agent: Mutt/1.5.6+20040907i X-Virus-Scanned: ClamAV 0.80/650/Sun Jan 2 19:00:02 2005 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 1067 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: horms@verge.net.au Precedence: bulk X-list: netdev Content-Length: 726 Lines: 25 On Mon, Jan 31, 2005 at 01:47:22AM -0800, Andrew Morton wrote: > Horms wrote: > > > > On Sun, Jan 30, 2005 at 10:33:02PM -0800, akpm@osdl.org wrote: > > > > > > > > > update_defense_level() is calling si_meminfo() from timer context. But > > > si_meminfo takes non-irq-safe locks. > > > > > > Move it all to keventd context. > > > > Would I be right in thinking that the offending lock is bdev_lock which > > is grabbed in nr_blockdev_pages() and thus that this is not an issue > > for 2.4 whose si_meminfo() does not have such a call? > > Yes, 2.4's si_meminfo() seems to be OK from interrupt context. Thanks. > On x86 - I didn't check the other architectures. Me neither. -- Horms