Received: with ECARTIS (v1.0.0; list netdev); Mon, 31 Jan 2005 01:47:38 -0800 (PST) Received: from mail.osdl.org (fw.osdl.org [65.172.181.6]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j0V9lUlW029127 for ; Mon, 31 Jan 2005 01:47:31 -0800 Received: from bix (build.pdx.osdl.net [172.20.1.2]) by mail.osdl.org (8.11.6/8.11.6) with SMTP id j0V9lKl25881; Mon, 31 Jan 2005 01:47:20 -0800 Date: Mon, 31 Jan 2005 01:47:22 -0800 From: Andrew Morton To: Horms Cc: davem@davemloft.net, netdev@oss.sgi.com Subject: Re: [patch 2/2] ipvs deadlock fix Message-Id: <20050131014722.77d732c4.akpm@osdl.org> In-Reply-To: <20050131093609.GA3804@verge.net.au> References: <200501310633.j0V6X1l01385@mail.osdl.org> <20050131093609.GA3804@verge.net.au> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.80/650/Sun Jan 2 19:00:02 2005 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 1063 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: akpm@osdl.org Precedence: bulk X-list: netdev Content-Length: 598 Lines: 17 Horms wrote: > > On Sun, Jan 30, 2005 at 10:33:02PM -0800, akpm@osdl.org wrote: > > > > > > update_defense_level() is calling si_meminfo() from timer context. But > > si_meminfo takes non-irq-safe locks. > > > > Move it all to keventd context. > > Would I be right in thinking that the offending lock is bdev_lock which > is grabbed in nr_blockdev_pages() and thus that this is not an issue > for 2.4 whose si_meminfo() does not have such a call? Yes, 2.4's si_meminfo() seems to be OK from interrupt context. On x86 - I didn't check the other architectures.