Received: with ECARTIS (v1.0.0; list netdev); Sun, 30 Jan 2005 22:41:59 -0800 (PST) Received: from mail.osdl.org (fw.osdl.org [65.172.181.6]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j0V6fsYF016562 for ; Sun, 30 Jan 2005 22:41:55 -0800 Received: from bix (build.pdx.osdl.net [172.20.1.2]) by mail.osdl.org (8.11.6/8.11.6) with SMTP id j0V6fll02446; Sun, 30 Jan 2005 22:41:48 -0800 Date: Sun, 30 Jan 2005 22:41:49 -0800 From: Andrew Morton To: davem@davemloft.net, netdev@oss.sgi.com, arjan@infradead.org Subject: Re: [patch 1/2] cancel_rearming_delayed_work() Message-Id: <20050130224149.29bb18a0.akpm@osdl.org> In-Reply-To: <200501310633.j0V6X0l01364@mail.osdl.org> References: <200501310633.j0V6X0l01364@mail.osdl.org> X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.80/650/Sun Jan 2 19:00:02 2005 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 1054 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: akpm@osdl.org Precedence: bulk X-list: netdev Content-Length: 730 Lines: 19 akpm@osdl.org wrote: > > Add library functions to reliably kill off a delayed work whose handler > re-adds the delayed work. One for keventd, one for caller-owned workqueues. > DESC > make cancel_rearming_delayed_workqueue static > EDESC > From: Arjan van de Ven > > cancel_rearming_delayed_workqueue() is only used inside workqueue.c; make > this function static (the more useful wrapper around it later in that > function remains non-static and exported) hmm, actually, had I paid any attention to Arjan's patch I'd have dropped it ;) cancel_rearming_delayed_workqueue() make sense and should be part of the workqueue API, even if nothing uses it yet. Whatever - we can fix that up sometime.