Received: with ECARTIS (v1.0.0; list netdev); Wed, 26 Jan 2005 21:21:57 -0800 (PST) Received: from arnor.apana.org.au (mail@arnor.apana.org.au [203.14.152.115]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j0R5LlJq017428 for ; Wed, 26 Jan 2005 21:21:48 -0800 Received: from gondolin.me.apana.org.au ([192.168.0.6] ident=mail) by arnor.apana.org.au with esmtp (Exim 3.35 #1 (Debian)) id 1Cu25u-0006Jt-00; Thu, 27 Jan 2005 16:21:26 +1100 Received: from herbert by gondolin.me.apana.org.au with local (Exim 3.36 #1 (Debian)) id 1Cu25S-0000as-00; Thu, 27 Jan 2005 16:20:58 +1100 Date: Thu, 27 Jan 2005 16:20:58 +1100 To: Kazunori Miyazawa Cc: davem@davemloft.net, netdev@oss.sgi.com, usagi-core@linux-ipv6.org Subject: Re: [PATCH][IPsec] fix process of error from crypto module Message-ID: <20050127052058.GB2060@gondor.apana.org.au> References: <41F87368.7060909@miyazawa.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41F87368.7060909@miyazawa.org> User-Agent: Mutt/1.5.6+20040722i From: Herbert Xu X-Virus-Scanned: ClamAV 0.80/650/Sun Jan 2 19:00:02 2005 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 843 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: herbert@gondor.apana.org.au Precedence: bulk X-list: netdev Content-Length: 662 Lines: 18 On Thu, Jan 27, 2005 at 01:51:52PM +0900, Kazunori Miyazawa wrote: > > BTW, esp6_destroy seem to be similar to esp_destroy. > Should we export esp_destroy and IPv4 and IPv6 use it? > Do we have any reason to define the functions separately? esp_destroy is certainly not the only function that can be merged. One of my dreams is to abstract out the family-dependent code from ah/esp/ipcomp so that we can have a family-independent code base. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt