Received: with ECARTIS (v1.0.0; list netdev); Sat, 22 Jan 2005 15:06:00 -0800 (PST) Received: from fr.zoreil.com (electric-eye.fr.zoreil.com [213.41.134.224]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j0MN5j3U003069 for ; Sat, 22 Jan 2005 15:05:46 -0800 Received: from electric-eye.fr.zoreil.com (localhost.localdomain [127.0.0.1]) by fr.zoreil.com (8.13.1/8.12.1) with ESMTP id j0MN24sH025877; Sun, 23 Jan 2005 00:02:04 +0100 Received: (from romieu@localhost) by electric-eye.fr.zoreil.com (8.13.1/8.13.1/Submit) id j0MN1uiQ025876; Sun, 23 Jan 2005 00:01:56 +0100 Date: Sun, 23 Jan 2005 00:01:56 +0100 From: Francois Romieu To: Richard Dawe Cc: netdev@oss.sgi.com Subject: Re: Acer Aspire 1524WLMi and RealTek 8169 - very slow Message-ID: <20050122230156.GC24461@electric-eye.fr.zoreil.com> References: <41A09541.5040405@phekda.gotadsl.co.uk> <41A0F0D5.9050702@phekda.gotadsl.co.uk> <20041121205814.GA22460@electric-eye.fr.zoreil.com> <41A24F35.5080106@phekda.gotadsl.co.uk> <20041122213008.GA9618@electric-eye.fr.zoreil.com> <41D2844E.5070204@phekda.gotadsl.co.uk> <20041229235203.GA5465@electric-eye.fr.zoreil.com> <41F250D1.8000207@phekda.gotadsl.co.uk> <41F26FD1.2060407@phekda.gotadsl.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41F26FD1.2060407@phekda.gotadsl.co.uk> User-Agent: Mutt/1.4.1i X-Organisation: Land of Sunshine Inc. X-Virus-Scanned: ClamAV 0.80/650/Sun Jan 2 19:00:02 2005 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 656 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: romieu@fr.zoreil.com Precedence: bulk X-list: netdev Richard Dawe : [...] > So I looked at the latest RealTek driver for Linux (version 220) and > that has some separate initialisation code for RTL_GIGA_MAC_VER_X > (MCFG_METHOD_4, they call it). I ported that over to r8169.c in > 2.6.11-rc1 and it appears to work. Nice. Have you checked that ethtool performs correctly when you try to set the link parameters with the new code (+ plug/unplug cable) ? > Attached is the patch against 2.6.11-rc1. I'm not sure if it caters to > your tastes. Maybe you'll want to rename RTL_GIGA_MAC_VER_X. I'll change the braces placement, the tab/spaces mix and push it. Please include something like the line below in your future patches: Signed-off-by: Richard Dawe Thanks. -- Ueimor