Received: with ECARTIS (v1.0.0; list netdev); Wed, 19 Jan 2005 17:22:18 -0800 (PST) Received: from fr.zoreil.com (electric-eye.fr.zoreil.com [213.41.134.224]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j0K1MCaX006146 for ; Wed, 19 Jan 2005 17:22:13 -0800 Received: from electric-eye.fr.zoreil.com (localhost.localdomain [127.0.0.1]) by fr.zoreil.com (8.13.1/8.12.1) with ESMTP id j0K1HhrP007217; Thu, 20 Jan 2005 02:17:43 +0100 Received: (from romieu@localhost) by electric-eye.fr.zoreil.com (8.13.1/8.13.1/Submit) id j0K1HUwF007196; Thu, 20 Jan 2005 02:17:30 +0100 Date: Thu, 20 Jan 2005 02:17:30 +0100 From: Francois Romieu To: "David S. Miller" Cc: shemminger@osdl.org, hadi@cyberus.ca, iod00d@hp.com, eric.lemoine@gmail.com, roland@topspin.com, netdev@oss.sgi.com, ak@suse.de, openib-general@openib.org, kaber@trash.net Subject: Re: [openib-general] Re: LLTX and netif_stop_queue Message-ID: <20050120011729.GA6775@electric-eye.fr.zoreil.com> References: <5cac192f05010308414a25b548@mail.gmail.com> <527jmu8nbw.fsf@topspin.com> <5cac192f0501030907c755135@mail.gmail.com> <20050103171227.GD7370@esmail.cup.hp.com> <1104812294.1085.53.camel@jzny.localdomain> <20050119144711.3fdd3d93.davem@davemloft.net> <20050119151853.259de49a@dxpl.pdx.osdl.net> <20050119154132.68f0bb4f.davem@davemloft.net> <20050120004753.GB2330@electric-eye.fr.zoreil.com> <20050119165247.5d4cec51.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050119165247.5d4cec51.davem@davemloft.net> User-Agent: Mutt/1.4.1i X-Organisation: Land of Sunshine Inc. X-Virus-Scanned: ClamAV 0.80/650/Sun Jan 2 19:00:02 2005 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 523 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: romieu@fr.zoreil.com Precedence: bulk X-list: netdev David S. Miller : [...] > Hmmm... ok then. Unfortunately, my prototype patch I just posted > will make IRQs get disabled in the ->hard_start_xmit() path. I'm completely fine with the prototype patch. It will allow to cut some code in the driver and the r8169 has room for improvement anyway. Point taken for the close() routine. -- Ueimor