Received: with ECARTIS (v1.0.0; list netdev); Fri, 14 Jan 2005 14:03:40 -0800 (PST) Received: from cheetah.davemloft.net (mail@adsl-63-197-226-105.dsl.snfc21.pacbell.net [63.197.226.105]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j0EM3XKM003751 for ; Fri, 14 Jan 2005 14:03:34 -0800 Received: from localhost ([127.0.0.1] helo=cheetah.davemloft.net ident=davem) by cheetah.davemloft.net with smtp (Exim 3.36 #1 (Debian)) id 1CpZQS-0005n3-00; Fri, 14 Jan 2005 13:56:12 -0800 Date: Fri, 14 Jan 2005 13:56:12 -0800 From: "David S. Miller" To: "chas williams - CONTRACTOR" Cc: netdev@oss.sgi.com Subject: Re: [RFC] locking changes for lec.c Message-Id: <20050114135612.0edc180d.davem@davemloft.net> In-Reply-To: <200501061717.j06HHJ5I000508@ginger.cmf.nrl.navy.mil> References: <200501061717.j06HHJ5I000508@ginger.cmf.nrl.navy.mil> X-Mailer: Sylpheed version 1.0.0rc (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.80/650/Sun Jan 2 19:00:02 2005 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 261 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: davem@davemloft.net Precedence: bulk X-list: netdev On Thu, 06 Jan 2005 12:17:20 -0500 "chas williams - CONTRACTOR" wrote: > after looking at things recently its not clear to me that the combination > of lec_arp_lock and lec_arp_users was protecting things properly. > here is a small rewrite that eliminates lec_arp_users completely and > uses lec_arp_lock to protect the lists in lec_prev: lec_arp_tables, > lec_arp_empty_ones, et al. Can HW interrupt paths ever call into this ARP stuff? If not, probably should just use BH disabled locking instead of the heavy handed IRQ disabling locks.