Received: with ECARTIS (v1.0.0; list netdev); Sun, 30 Jan 2005 19:33:55 -0800 (PST) Received: from mx01.cybersurf.com (mx01.cybersurf.com [209.197.145.104]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j0V3XpsL030623 for ; Sun, 30 Jan 2005 19:33:52 -0800 Received: from mail.cyberus.ca ([209.197.145.21]) by mx01.cybersurf.com with esmtp (Exim 4.30) id 1CvSJz-0000Li-0E for netdev@oss.sgi.com; Sun, 30 Jan 2005 22:33:51 -0500 Received: from cpe0030ab124d2f-cm014500000962.cpe.net.cable.rogers.com ([24.103.99.32] helo=[10.0.0.9]) by mail.cyberus.ca with esmtp (Exim 4.20) id 1CvSJw-0004A9-2l; Sun, 30 Jan 2005 22:33:48 -0500 Subject: Re: LLTX fix proposal From: jamal Reply-To: hadi@cyberus.ca To: "David S. Miller" Cc: netdev@oss.sgi.com In-Reply-To: <20050130181854.7f088a95.davem@davemloft.net> References: <20050130181854.7f088a95.davem@davemloft.net> Content-Type: text/plain Organization: jamalopolous Message-Id: <1107142423.8021.114.camel@jzny.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 Date: 30 Jan 2005 22:33:43 -0500 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.80/650/Sun Jan 2 19:00:02 2005 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 1033 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: hadi@cyberus.ca Precedence: bulk X-list: netdev Content-Length: 632 Lines: 21 On Sun, 2005-01-30 at 21:18, David S. Miller wrote: > Ok, how about we do this for 2.6.11 before it goes out and > do something more sophisticated (if necessary) later. > > The BUG() we're trying to catch in the ->hard_start_xmit() > routines is the illegal state: > > driver_tx_queue_empty() && !netif_queue_stopped(dev) > In the e1000 theres a lot more code in hard_start_xmit() that could be possibly entered before you hit the xmit lock. So thats another potential issue. The tg3 you refer to in your email doesnt seem to be as bad and i am actually wondering why what you just posted is _the fix_ as is. cheers, jamal