Received: with ECARTIS (v1.0.0; list netdev); Sun, 30 Jan 2005 16:09:59 -0800 (PST)
Received: from mx02.cybersurf.com (mx02.cybersurf.com [209.197.145.105])
	by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j0V09s5W019120
	for <netdev@oss.sgi.com>; Sun, 30 Jan 2005 16:09:55 -0800
Received: from mail.cyberus.ca ([209.197.145.21])
	by mx02.cybersurf.com with esmtp (Exim 4.30)
	id 1CvP8b-0002Jl-Cg
	for netdev@oss.sgi.com; Sun, 30 Jan 2005 19:09:53 -0500
Received: from cpe0030ab124d2f-cm014500000962.cpe.net.cable.rogers.com ([24.103.99.32] helo=[10.0.0.9])
	by mail.cyberus.ca with esmtp (Exim 4.20)
	id 1CvP8Q-0003db-JO; Sun, 30 Jan 2005 19:09:42 -0500
Subject: Re: [patch 4/10] s390: network driver.
From: jamal <hadi@cyberus.ca>
Reply-To: hadi@cyberus.ca
To: Tommy Christensen <tommy.christensen@tpack.net>
Cc: Jeff Garzik <jgarzik@pobox.com>,
        Thomas Spatzier <thomas.spatzier@de.ibm.com>,
        "David S. Miller" <davem@davemloft.net>,
        Hasso Tepper <hasso@estpak.ee>,
        Herbert Xu <herbert@gondor.apana.org.au>, netdev@oss.sgi.com,
        Paul Jakma <paul@clubi.ie>
In-Reply-To: <41FD702D.2060403@tpack.net>
References: 
	 <OFB7F7E23F.EFB88418-ONC1256F7E.0031769E-C1256F7E.003270AD@de.ibm.com>
	 <1104764710.1048.580.camel@jzny.localdomain>  <41DB26A6.2070008@pobox.com>
	 <1104895169.1117.63.camel@jzny.localdomain>  <41DC0931.80603@tpack.net>
	 <1105019912.2314.20.camel@jzny.localdomain>
	 <1105023972.3462.48.camel@tsc-6.cph.tpack.net>
	 <1105104757.1046.63.camel@jzny.localdomain>
	 <1105111605.3462.101.camel@tsc-6.cph.tpack.net>
	 <1105363092.1041.146.camel@jzny.localdomain>
	 <1105917038.1091.1041.camel@jzny.localdomain> <41EC3067.6050104@tpack.net>
	 <41FD702D.2060403@tpack.net>
Content-Type: text/plain
Organization: jamalopolous
Message-Id: <1107130177.7847.96.camel@jzny.localdomain>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.2.2 
Date: 30 Jan 2005 19:09:38 -0500
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV 0.80/650/Sun Jan  2 19:00:02 2005
	clamav-milter version 0.80j
	on 127.0.0.1
X-Virus-Status: Clean
X-archive-position: 1025
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: hadi@cyberus.ca
Precedence: bulk
X-list: netdev
Content-Length: 299
Lines: 14

Tommy,

I wasnt sure why you did:

dev->qdisc = &noop_qdisc;

You should probably save the old qdisc in qdisc_sleeping instead
and restore it on wakeup - otherwise you always end with default qdisc.
check_carrier should probably just call dev_activate which does all you
wanted, no?

cheers,
jamal