Received: with ECARTIS (v1.0.0; list netdev); Sun, 23 Jan 2005 08:08:42 -0800 (PST)
Received: from null.rsn.bth.se (postfix@null.rsn.bth.se [194.47.142.3])
	by oss.sgi.com (8.13.0/8.13.0) with ESMTP id j0NG8ZhR022564
	for <netdev@oss.sgi.com>; Sun, 23 Jan 2005 08:08:36 -0800
Received: by null.rsn.bth.se (Postfix, from userid 65534)
	id 9A12D2C00B1; Sun, 23 Jan 2005 17:08:30 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by null.rsn.bth.se (Postfix) with ESMTP id 3E1482C00B3;
	Sun, 23 Jan 2005 17:08:30 +0100 (CET)
Received: from tux.rsn.bth.se (tux.rsn.bth.se [194.47.143.135])
	by null.rsn.bth.se (Postfix) with ESMTP id 759D72C00B1;
	Sun, 23 Jan 2005 17:08:29 +0100 (CET)
Received: by tux.rsn.bth.se (Postfix, from userid 501)
	id BE2143FB5; Sun, 23 Jan 2005 17:08:29 +0100 (CET)
Subject: Re: [PATCH/RFC] Reduce call chain length in netfilter (was: Re:
	do_IRQ: stack overflow: 872..)
From: Martin Josefsson <gandalf@wlug.westbo.se>
To: Bart De Schuymer <bdschuym@pandora.be>
Cc: "David S. Miller" <davem@davemloft.net>, shemminger@osdl.org,
        dwmw2@infradead.org, ak@suse.de, snort2004@mail.ru, bridge@osdl.org,
        netdev@oss.sgi.com, Rusty Russell <rusty@rustcorp.com.au>
In-Reply-To: <1106484019.3376.5.camel@localhost.localdomain>
References: <1131604877.20041218092730@mail.ru.suse.lists.linux.kernel>
	 <p73zn0ccaee.fsf@verdi.suse.de>
	 <1105117559.11753.34.camel@baythorne.infradead.org>
	 <20050107100017.454ddadc@dxpl.pdx.osdl.net>
	 <1105133241.3375.16.camel@localhost.localdomain>
	 <20050118135735.4b77d38d.davem@davemloft.net>
	 <1106433059.4486.11.camel@localhost.localdomain>
	 <1106436153.20995.42.camel@tux.rsn.bth.se>
	 <1106484019.3376.5.camel@localhost.localdomain>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-fuimzzHstOWacJ6oQqa5"
Date: Sun, 23 Jan 2005 17:08:29 +0100
Message-Id: <1106496509.1085.1.camel@tux.rsn.bth.se>
Mime-Version: 1.0
X-Mailer: Evolution 2.0.3 
X-Virus-Scanned: ClamAV 0.80/650/Sun Jan  2 19:00:02 2005
	clamav-milter version 0.80j
	on 127.0.0.1
X-Virus-Scanned: by amavisd-new-20030616-p10 on null.rsn.bth.se
X-Virus-Status: Clean
X-archive-position: 667
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: gandalf@wlug.westbo.se
Precedence: bulk
X-list: netdev
Content-Length: 1304
Lines: 51


--=-fuimzzHstOWacJ6oQqa5
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sun, 2005-01-23 at 13:40 +0100, Bart De Schuymer wrote:

> Hi Martin,

Hi Bart

> > I guess you never testcompiled with CONFIG_NETFILTER_DEBUG set :)
>=20
> Oops, no. I was imagining I could code that without error...
> There was another compile error with CONFIG_NETFILTER_DEBUG in the patch
> (skb that should have been (*pskb)) :(

:)

> > > +			if (verdict > NF_MAX_VERDICT) {
> > > +				NFDEBUG("Evil return from %p(%u).\n",
> > > +				        elem->hook, hook);
> > > +				continue;
> > > +			}
> >=20
> > Maybe add unlikely() around the test?
>=20
> OK. I added another one around another debugging if-statement.

I'm now running a kernel with this patch and everything seems to still
be working.
So unless someone else has something to comment I think this should be
applied.
The decrease in call-depth is important.

--=20
/Martin

--=-fuimzzHstOWacJ6oQqa5
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQBB88v8Wm2vlfa207ERAr8iAKCnEC6wtsFBsBXnNqjMy9u9gt/TjQCeM2BL
qaJeTtbB5wOKFi7J9BfBX4E=
=3U0/
-----END PGP SIGNATURE-----

--=-fuimzzHstOWacJ6oQqa5--