Received: with ECARTIS (v1.0.0; list netdev); Wed, 29 Dec 2004 19:41:37 -0800 (PST)
Received: from kaber.coreworks.de ([62.206.217.67])
	by oss.sgi.com (8.13.0/8.13.0) with ESMTP id iBU3f5bg032647
	for <netdev@oss.sgi.com>; Wed, 29 Dec 2004 19:41:26 -0800
Received: from eru.coreworks.de ([172.16.0.2] helo=trash.net)
	by kaber.coreworks.de with esmtp (Exim 4.34)
	id 1CjrDD-0002Je-2l; Thu, 30 Dec 2004 04:42:55 +0100
Message-ID: <41D378FF.3080205@trash.net>
Date: Thu, 30 Dec 2004 04:41:51 +0100
From: Patrick McHardy <kaber@trash.net>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5
X-Accept-Language: en
MIME-Version: 1.0
To: jamal <hadi@cyberus.ca>
CC: Maillist netdev <netdev@oss.sgi.com>
Subject: [PATCH PKT_SCHED 17/17]: Disable broken override bits in pedit action
Content-Type: multipart/mixed;
 boundary="------------020300080003090501060808"
X-Virus-Scanned: ClamAV 0.80/638/Tue Dec 21 14:41:34 2004
	clamav-milter version 0.80j
	on 127.0.0.1
X-Virus-Status: Clean
X-archive-position: 13195
X-ecartis-version: Ecartis v1.0.0
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
X-original-sender: kaber@trash.net
Precedence: bulk
X-list: netdev

This is a multi-part message in MIME format.
--------------020300080003090501060808
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Disable broken override bits in pedit action. It misses
locking and needs to allocate new memory if nkeys increases.
Also disable it for now.


--------------020300080003090501060808
Content-Type: text/x-patch;
 name="17.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="17.diff"

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/12/30 03:56:27+01:00 kaber@coreworks.de 
#   [PKT_SCHED]: Disable broken override bits in pedit action
#   
#   Signed-off-by: Patrick McHardy <kaber@trash.net>
# 
# net/sched/pedit.c
#   2004/12/30 03:56:20+01:00 kaber@coreworks.de +2 -0
#   [PKT_SCHED]: Disable broken override bits in pedit action
#   
#   Signed-off-by: Patrick McHardy <kaber@trash.net>
# 
diff -Nru a/net/sched/pedit.c b/net/sched/pedit.c
--- a/net/sched/pedit.c	2004-12-30 04:02:10 +01:00
+++ b/net/sched/pedit.c	2004-12-30 04:02:10 +01:00
@@ -83,6 +83,8 @@
 
 	ret = -EEXIST;
 	if (ovr) {
+		/* FIXME: no locking, larger memory area might be required */
+		return -EOPNOTSUPP;
 		ret = 0;
 override:
 		p->flags = parm->flags;

--------------020300080003090501060808--