Received: with ECARTIS (v1.0.0; list netdev); Fri, 31 Dec 2004 03:55:17 -0800 (PST) Received: from b.mx.projectdream.org (eth0-0.arisu.projectdream.org [194.158.4.191]) by oss.sgi.com (8.13.0/8.13.0) with ESMTP id iBVBsnUi017677 for ; Fri, 31 Dec 2004 03:55:10 -0800 Received: from postel.suug.ch (unknown [195.134.158.23]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by b.mx.projectdream.org (Postfix) with ESMTP id 4AD4AF; Fri, 31 Dec 2004 13:03:02 +0100 (CET) Received: by postel.suug.ch (Postfix, from userid 10001) id B470A1C0EA; Fri, 31 Dec 2004 13:03:44 +0100 (CET) Date: Fri, 31 Dec 2004 13:03:44 +0100 From: Thomas Graf To: jamal Cc: "David S. Miller" , Patrick McHardy , netdev@oss.sgi.com Subject: Re: [PATCH 3/9] PKT_SCHED: u32: make use of tcf_exts API Message-ID: <20041231120344.GH32419@postel.suug.ch> References: <20041230122652.GM32419@postel.suug.ch> <20041230123108.GP32419@postel.suug.ch> <1104468201.1047.201.camel@jzny.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1104468201.1047.201.camel@jzny.localdomain> X-Virus-Scanned: ClamAV 0.80/645/Mon Dec 27 14:56:20 2004 clamav-milter version 0.80j on 127.0.0.1 X-Virus-Status: Clean X-archive-position: 13288 X-ecartis-version: Ecartis v1.0.0 Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com X-original-sender: tgraf@suug.ch Precedence: bulk X-list: netdev * jamal <1104468201.1047.201.camel@jzny.localdomain> 2004-12-30 23:43 > On Thu, 2004-12-30 at 07:31, Thomas Graf wrote: > > > > > +static struct tcf_ext_map u32_ext_map = { > > + .action = TCA_U32_ACT, > > + .police = TCA_U32_POLICE > > +}; > > Repeated on all classifiers - perhaps a little macro magic in order? ;-> I thought about this but couldn't come up with one that makes it actually easier. I don't want to hardcode action/police in a macro because we might have extensions only needed for specific classifiers. > Generally rest all looking good - I need to stare some more at the route > and tcindex one but dont see any show stoppers off hand; Yes please, those are the critical points.